Giter Site home page Giter Site logo

Comments (2)

mschreter avatar mschreter commented on August 23, 2024 1

@kronbichler It looks now much better, using dealii/dealii#16776 adaflo (and MeltPoolDG) compiles now without any compatibility changes :-). This should be a good sign since we consider many 1D cases. Thank you very much for the quick fix.

from adaflo.

kronbichler avatar kronbichler commented on August 23, 2024

I see the point; it seems that the tests in deal.II are less comprehensive than I thought they are, so anyway this indicates we should work towards additional 1D tests. My apologies for not testing here, this is an oversight.
In my later PR dealii/dealii#16776, I indeed enabled get_divergence for 1D due to the benefits. I think we should aim to avoid the constexpr cases as you introduced them here, and I think we can get all the features into the now single call function. I think we should start from the latter PR because, as you state correctly, it again changes some of the edge cases. We should discuss it there and try to edge out possible incompatibilities for the 1D case. Essentially, the problem there can be traced back to the missing compatibility layer we had for 1D/vector-valued variables. I added two functions now to dealii/dealii#16776, can you check again?

from adaflo.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.