Comments (2)
@kronbichler It looks now much better, using dealii/dealii#16776 adaflo (and MeltPoolDG) compiles now without any compatibility changes :-). This should be a good sign since we consider many 1D cases. Thank you very much for the quick fix.
from adaflo.
I see the point; it seems that the tests in deal.II are less comprehensive than I thought they are, so anyway this indicates we should work towards additional 1D tests. My apologies for not testing here, this is an oversight.
In my later PR dealii/dealii#16776, I indeed enabled get_divergence
for 1D due to the benefits. I think we should aim to avoid the constexpr
cases as you introduced them here, and I think we can get all the features into the now single call function. I think we should start from the latter PR because, as you state correctly, it again changes some of the edge cases. We should discuss it there and try to edge out possible incompatibilities for the 1D case. Essentially, the problem there can be traced back to the missing compatibility layer we had for 1D/vector-valued variables. I added two functions now to dealii/dealii#16776, can you check again?
from adaflo.
Related Issues (9)
- question about phase field solver
- See over test and their run time HOT 2
- Check the ghost state of vectors
- Update version of clang-format to v.11 to be consistent with deal.II master HOT 1
- Add parameter `output memory`
- Override warning [-Wsuggest-override]
- 1D: Nonlinear solver for the Navier-Stokes equations does not converge anymore HOT 5
- Introduce namespace `adaflo` HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from adaflo.