No testing of validation errors in KZPropertyMapperValidatorTests.m

[krzysztofzablocki]

No testing of validation errors in KZPropertyMapperValidatorTests.m

[krzysztofzablocki]

Right now If that method failed then all validators tests would since all validations paths use this method internally, but that's implementation detail and I agree we should test that method directly as well.

Any chance you could add few tests for that and send me PR? I've too much on my plate to add it now, but I'm thinking that tests like this should suffice considering tests already in validation suite:

• empty/non-existing array if there are no validations issues
• single error on 1 validation issue
• 4 errors on 4 issues

[BoneDesert]

I've actually found this deffeciency as I have an issue implementing the call in my own app's test code and was looking for an example of use to see where I was going wrong. Its to do with the set-up of the NSArray __autoreleasing ** array and how to operate on it. Xcode is freaking out at me:

- (BOOL)validateWeatherDataPresence {
    self.weatherData = [NSArray new];
    __autoreleasing NSArray **validationErrors;

    BOOL result = [KZPropertyMapper mapValuesFrom:self.webSourcedData toInstance:self usingMapping:@{
        @"data" : @{
            @"weather": KZProperty(weatherData).isRequired()
        }
    } errors:validationErrors];


    return result;
}

Xcode is reporting Argument in message expression is an uninitialised value ...

If I get it working (and get time) I'll certainly help.

[krzysztofzablocki]

that's not how you use output params in C based languages, also don't add __autoreleasing to variables, it's a description for a method interface not storage info on variable. Try this:

- (BOOL)validateWeatherDataPresence {
    self.weatherData = [NSArray new];
    NSArray *validationErrors;

    BOOL result = [KZPropertyMapper mapValuesFrom:self.webSourcedData toInstance:self usingMapping:@{
        @"data" : @{
            @"weather": KZProperty(weatherData).isRequired()
        }
    } errors:&validationErrors];

    return result;
}

For output params you use a pointer-to-pointer, more details are available here http://www.eskimo.com/~scs/cclass/int/sx8.html

PS. if you don't care about what errors are there you can call method that doesn't have errors, it will still work the same for your code since that BOOL return value is established as YES only if all validations succeded.

[BoneDesert]

doh! Of course it is. I'll definitely add the tests when I get a bit of time.

Thanks Krzysztof

[krzysztofzablocki]

👍 Send me a PR if you do, more tests are welcomed. Let me know if you need more help!