Giter Site home page Giter Site logo

Comments (4)

nuggreat avatar nuggreat commented on August 13, 2024

As all kOS does is call FlightGlobals.SetActiveVessel(vessel); or FlightGlobals.ForceSetActiveVessel(vessel); when you set those suffixes (code here) this sounds to me like KSP is doing something extra when you change vessel from within the IVA view that they really should have built into the methods.

from kos.

SofieBrink avatar SofieBrink commented on August 13, 2024

While true, since ksp won’t be getting those fixes anymore it does seem like something kOS will have to check for

from kos.

Dunbaratu avatar Dunbaratu commented on August 13, 2024

Chances are the stock KSP API never expected the UX to let a player switch scenes from inside IVA, so the problem it causes is never experienced in stock play.

There's a lot of these messy cases in KSP, where protections against Bad Things that really belong down in the API are only enforced by the UX code not providing the player with a button or keypress that would invoke the Bad Thing. (Thus why we ended up just banning NaN and Infinity in kOS mathematics because otherwise a player script can just take that NaN or Infinity and send it into a KSP API call that throws exception when it tries using the value.)

from kos.

JonnyOThan avatar JonnyOThan commented on August 13, 2024

@Dunbaratu see the note on my comment. You CAN switch vessels from IVA in stock (use square bracket keys) and the bug does not occur. It’s specific to whatever KOS is doing. More likely, the stock code is doing some other bookkeeping inside the button press handler in addition to actually switching vessels.

from kos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.