Giter Site home page Giter Site logo

Unable to finish Orbital Test Flight (Uncrewed) contract due to landed capsule not registering as "Return Home Safely". about rp-1 HOT 6 CLOSED

Karhgath avatar Karhgath commented on August 13, 2024
Unable to finish Orbital Test Flight (Uncrewed) contract due to landed capsule not registering as "Return Home Safely".

from rp-1.

Comments (6)

Karhgath avatar Karhgath commented on August 13, 2024

Other contracts did not seem to exhibit the same behavior, even if using the same craft file. Not sure what happened with this contract or it was something situational.

from rp-1.

siimav avatar siimav commented on August 13, 2024

The real problem is that "Stay in specified orbit for the duration" parameter is already ticked green while the vessel is sitting on the launch pad. Looks like somehow a previous vessel completed it and for whatever reason it doesn't get recalculated for the new vessel.

from rp-1.

siimav avatar siimav commented on August 13, 2024

Did some more digging and there's 2 separate issues here.
The "return home" parameter doesn't complete because "crew capacity" flipped to unmet status. In some cases the contract widget doesn't update it immediately even though internally the status has already changed.
The other issue is All parameter getting stuck in completed status from other vessels/launches. This is due to it having disableOnStateChange = true coupled with the fact that it doesn't derive from VesselParameter and thus doesn't know how to track multiple vessels at the same time. Unfortunately there doesn't appear to be a VesselParameter that would serve as an alternative for such wrappers.

from rp-1.

siimav avatar siimav commented on August 13, 2024

Please test with this: KSP-RO/ContractConfigurator#30

from rp-1.

siimav avatar siimav commented on August 13, 2024

"Stay in specified orbit for the duration" group needs to be rewritten in the old-style Duration wrapped inside Orbit since KSP-RO/ContractConfigurator#29 should properly support it now.

from rp-1.

Karhgath avatar Karhgath commented on August 13, 2024

Tested the above fix from my posted save, I am also nearing orbit in another one and will try there later

  • Normal launch and recovery worked. The requirements were not fluctuating during the whole mission, like when staging.
  • Normal launch, switching to another vessel, and coming back worked. The requirements were invalidated on the other vessel, but came back green when switched back. Recovery worked.
  • Normal launch, changing back to space center and fiddling around, and coming back. Working perfectly.
  • Launched with the Mercury control module which caused #2282 before. No issues with fluctuating requirements.

image

So both issues seem fixed now.

I will keep using the new CC in my current game and see if it's stable as well.

from rp-1.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.