Contracts do not appear when using TextureReplacer

[ksp-ro]

Contracts do not appear when using TextureReplacer

[NathanKell]

Mod list and player.log pls? Can't replicate.

[pjf]

Oh what, you expect at least the same level of detail as I expect from my users? :P

$ ckan.exe list

KSP found at /home/pjf/.steam/steam/SteamApps/common/Kerbal Space Program

KSP Version: 0.25.0

Installed Modules:

✓ AGExt 1.23
✓ AJE 1.6.4
✓ AlternateResourcePanel 2.6.1.0
✓ Chatterer 0.7.1
✓ CIT-Util 1.0.4-unofficial
✓ CommunityResourcePack 0.2.3
✓ CommunityTechTree 1.1
✓ CrossFeedEnabler v3.1
✓ CustomBiomes 1.6.8
✓ CustomBiomes-Data-RSS v8.2.1
✓ DeadlyReentry v6.2.1
✓ DMagicOrbitalScience 0.8.6.1
✓ DogeCoinFlag 1.02
✓ EngineIgnitor-Unofficial-Repack 3.4.1.1
✓ FerramAerospaceResearch v0.14.3.2
✓ FinePrint 0.59
✓ FirespitterCore 7.0.5398.27328
✓ HotRockets 7.25
✓ Karbonite 0.4.4
✓ KAS 0.4.9
✓ KerbalAlarmClock v3.0.5.0
✓ KerbalConstructionTime 1.0.3
✓ KerbalJointReinforcement v2.4.4
✓ kOS 0.15.2
✓ MechJeb2 2.4.0
✓ ModuleManager 2.5.1
✓ ModuleRCSFX v3.3
✓ ORSX 0.1.3
✓ PartCatalog 3.0_RC8
✓ PlanetShine 0.2.2
✓ PreciseNode 1.1.1
✓ ProceduralDynamics 0.9.1
✓ ProceduralFairings v3.10
✓ ProceduralParts v0.9.19
✓ RealChute 1.2.6
✓ RealFuels rf-v8.1
✓ RealismOverhaul v7.0.1
✓ RealSolarSystem v8.2.1
✓ RemoteTech v1.5.1
✓ RP-0 v0.08
✓ RSSTextures4096 1.0
✓ SCANsat v8.0
✓ ScienceAlert 1.8rc1
✓ ShipManifest 0.25.0_3.3.2b
✓ StageRecovery 1.5.1
✓ SXT 18.6
✓ TACLS v0.10.1
✓ TACLS-Config-RealismOverhaul v7.0.1
✓ TechManager 1.4
✓ TextureReplacer 1.9.2
✓ Toolbar 1.7.7
✓ TweakScale v1.47
✓ UKS 0.21.3
✓ USITools 0.2.4

Legend: ✓ - Up to date. ✗ - Incompatible. ↑ - Upgradable. ? - Unknown 

Player log: https://dl.dropboxusercontent.com/u/9702672/KSP/playerlog-rp0-24.zip

[NathanKell]

1. Roll back to Tweakscale 1.44; later versions have serious issues.
2. PlanetShine is throwing.
3. SXT/Agencies/KDB is unreadable. However, I get that error too and things work for me. Nonetheless rbray needs to hear of it.
4. ActionGroupsExtended throws in EditorSaveToFile
5. KAC throws in FillWindow
6. AGE throws more, as does KAC.
7. RealChute throws in get_groundstop.

With the exception of SXT, and rolling back tweakscale, try without all those mods.

[pjf]

But those are a random set of mods I installed from testing CKAN packages I love AGExt and it worked fine under 0.23.5 😜 .

[NathanKell]

...

[NathanKell]

On the off chance that SXT problem is worse for you than for me, you can nuke the SXT/Agencies folder and see if that helps (after cutting down to a minimal install :P )

[pjf]

Don't I need RealChute for RP-0/RO?

[NathanKell]

We put it in Recommends, like EngineIgnitor.

For recoverable sounding rockets you'll want either it or Tweakscale (otherwise you won't have small enough chutes), but neither is strictly required.

[pjf]

Okay, doing this from the start. Have a fresh install...

$ ./ckan.exe install --no-recommends RP-0 RSSTextures4096
About to install...

 * RP-0 v0.08 (cached)
 * RSSTextures4096 1.0 (cached)
 * ModuleManager 2.5.1
 * RealismOverhaul v7.0.2 (cached)
 * AJE 1.6.4 (cached)
 * FerramAerospaceResearch v0.14.3.2 (cached)
 * KerbalJointReinforcement v2.4.4 (cached)
 * ModuleRCSFX v3.3 (cached)
 * RealFuels rf-v8.1 (cached)
 * RealSolarSystem v8.2.1 (cached)
 * SXT 18.6 (cached)
 * ProceduralFairings v3.10 (cached)
 * CommunityTechTree 1.1 (cached)
 * TechManager 1.4 (cached)

Continue? [Y/N]

Let's see how this turns out.

[pjf]

Success! I can see the contracts! Now to find our culprit that's causing everything to go sad.

Do the "with a sounding rocket" have to be done with any special tech? Or can I do them with an airplane, blimp, or any other vehicle?

[pjf]

Adding:

• DeadlyReentry
• KerbalConstructionTime
• StageRecovery
• FinePrint

[NathanKell]

Awesome!
You can do them with anything. Just reach that altitude. But good luck reaching 2500km in a blimp :P
Oh, and for Teh Realismz, you really shouldn't be able to recover stages. ;)

[pjf]

And, we're still good.

Why can't I recover stages? They've got parachutes on them and everything.

[pjf]

Okay, I'm going to add everything else back in and let git bisect figure out what's wrong.

[NathanKell]

Because rocket motors don't burn more than once, and because heat. While you can, say, recover a booster, it usually costs almost as much to refurbish as to make a new one (and the volume discounts of mass-producing the component definitely beat the labor costs to hand-refurbish an individual stage). Something that has a shedload of design work for reusability might net you something like 25-50% savings over a new stage (that's what SpaceX hopes) but that's probably the limit with present materials technology.

[pjf]

For my own reference:

$ git bisect log
git bisect start
# bad: [4c99e0551af4feb019e01946b818382e309d5b7f] UKS
git bisect bad 4c99e0551af4feb019e01946b818382e309d5b7f
# good: [224964fe28b5c9a63f0f0d20e96dbc4c302f41c9] Added DRE, FinePrint, KCT, StageRecovery
git bisect good 224964fe28b5c9a63f0f0d20e96dbc4c302f41c9
# good: [0f3c17073e7282572eb810298194d98320ac4776] MechJeb2
git bisect good 0f3c17073e7282572eb810298194d98320ac4776
# good: [afad768b1769a227a98733efc0cccdccce6c069f] RealChute
git bisect good afad768b1769a227a98733efc0cccdccce6c069f
# good: [fb4e54eda0650b64a0825aa584281d84b5c84b2e] ScienceAlert
git bisect good fb4e54eda0650b64a0825aa584281d84b5c84b2e
# bad: [d61dfcd6c4330ab22a65ae2ada8e774c4a2b90b3] TextureReplacer
git bisect bad d61dfcd6c4330ab22a65ae2ada8e774c4a2b90b3
# good: [95838cbc8a623413ee970210fced86d833482c9a] ShipManifest
git bisect good 95838cbc8a623413ee970210fced86d833482c9a
# first bad commit: [d61dfcd6c4330ab22a65ae2ada8e774c4a2b90b3] TextureReplacer

Hypothesis presented by git is that it's TextureReplacer. I'm going to test this now.

[pjf]

Confirmed. TextureReplacer 1.10.2 causes the contracts to not appear. Removing it causes them to appear as per normal.

Hypothesis is that TextureReplacer is causing the agency flags to be unavailable, causing the attempts to generate those contracts to fail.

Renaming issue.

[pjf]

I'm trying to figure out where the bug here actually lies, and if this is something we can fix. Given that AFAIK flags always live inside a Flags directory, the obvious fix would be to change TextureReplacer not to compress flags (which aren't very big and don't use much memory anyway).

[pjf]

This no longer appears to be an issue with newer versions of TextureReplacer! Closing issue.

[jwvanderbeck]

Sorry but this is still a problem with TR unless there has been a version
released within the last days specifically to address it?

• John Vanderbeck
• http://www.johnvanderbeck.com

On Wed, Mar 4, 2015 at 6:40 PM, Paul Fenwick [email protected]
wrote:

Closed #24 #24.

—
Reply to this email directly or view it on GitHub
#24 (comment).

[NathanKell]

@pjf: the issue appears to be that TR can call a Unity call that fails during texture load, which corrupts configs in GameDatabase, thus screwing everything up. It's very much still a problem, I gather with your changed modset you are no longer affected?

[pjf]

Ah, dang. As the only other person on this ticket I was hoping this was a stale "just me" issue.

And yes, at least with my modset I'm not seeing any problems. Here's what that currently looks like:

KSP Version: 0.90.0

Installed Modules:

- ActiveTextureManagement-x64-Basic 4-3
- AdvancedJetEngine 2.0.3
- AGExt 1.30c
- AlternateResourcePanel 2.6.3.0
- BetterBuoyancy v1.1
- Chatterer 0.8.1
- CIT-Util 1.1.2
- CommunityResourcePack 0.3.3
- CommunityTechTree 1.1
- CrossFeedEnabler v3.2
- CustomBiomes v1.7.2
- CustomBiomes-Data-RSS v8.5
- DDSLoader 1.8.0.0
- DeadlyReentry v6.4.0
- DMagicOrbitalScience 0.9.2
- DogeCoinFlag v1.02
- EngineIgnitor-Unofficial-Repack 3.4.1.1-1
- EnhancedNavBall 1.3.5
? EVE-Overhaul-Core 0.0.2014.12.18
- FASA 5.215
- FerramAerospaceResearch v0.14.6
- FilterExtensions 1.17
- FinalFrontier 0.6.5-697
- FirespitterCore 7.0.5463.30802
- InfernalRobotics 0.19.3
- Karbonite 0.5.5
- KerbalAlarmClock v3.2.3.0
- KerbalConstructionTime 1.1.2
- KerbalJointReinforcement v3.1.1
- kOS 0.16.0
- KronalVesselViewer 0.0.4_0.90.0
- MechJeb2 2.4.2
- ModuleManager 2.5.9
- ModuleRCSFX v3.5
- PlanetShine 0.2.2.1
- PlanetShine-Config-Default 0.2.2.1
- PreciseNode 1.1.2
- ProceduralDynamics v0.9.3
- ProceduralFairings v3.11
- ProceduralParts v1.0.2
- RealChute 1.2.6.3
- RealFuels rf-v8.4
- RealismOverhaul v8.1.1
- RealPlume v8.1.1
- RealSolarSystem v8.5
- Regolith 0.1.7
- RemoteTech v1.6.3
^ RemoteTech-Config-RSS 0.0
- ResourceOverview 1.2.0.0
- RP-0 v0.24
- RSSTexturesDDS8192 1.0
? RVE-KSP-Haxx 0.0.2015.02.26
- SCANsat v10.0
- ScienceAlert 1.8.4
- Service-Compartments-6S 1.3
- ShipManifest 0.90.0_4.1.2
- SmokeScreen 2.5.3
- SXT 20
- TACLS v0.10.2b
- TACLS-Config-RealismOverhaul v8.1.1
- TechManager 1.5-compat
- TextureReplacer 2.2.5
- Toolbar 1.7.8
- TweakScale v1.50
- UKS 0.22.8
- UniversalStorage 1.0.90.2
- UniversalStorage-KAS Deprecated
- UniversalStorage-TAC Deprecated
- USITools 0.3.2
* VenStockRevamp v1.7.2

I believe the hypothesis was that TR was compressing flags. I'm guessing it's either stopped doing this, or more mods are coming with TR configs to protect their flags from compression.

[NathanKell]

It may be that an early version was, which might have been an issue, but AFAICT the current version is not. Oh! I think I may know. Agathorn, you're on Doze, right? The GameDatabase issue is a failed D3D call as I recall, but perhaps the Linux issue was the flags? But there's enough other linux folks who were experiencing the issue (posted on forum) that I don't think we can yet say with certainty the linux side is fixed.

[jwvanderbeck]

All I know is what Sarbian said, which is pretty much what you said :)
Thing is though that it could be anything that TR corrupts on.

• John Vanderbeck
• http://www.johnvanderbeck.com

On Wed, Mar 4, 2015 at 7:04 PM, NathanKell [email protected] wrote:

It may be that an early version was, which might have been an issue, but
AFAICT the current version is not. Oh! I think I may know. Agathorn, you're
on Doze, right? The GameDatabase issue is a failed D3D call as I recall,
but perhaps the Linux issue was the flags? But there's enough other
linux folks who were experiencing the issue (posted on forum) that I don't
think we can yet say with certainty the linux side is fixed.

—
Reply to this email directly or view it on GitHub
#24 (comment).

[nanoblack]

Disabling TR's texture unloading fixes the contract issues for me.

[jwvanderbeck]

I don't know what that unloading feature is, but the root of the problem is
that TR is sometimes failing to load textures and instead of handling the
error, it is instead corrupting the game database. Unfortunately despite
sarbian posting in the TR thread with all the details, i've yet to see Shaw
even acknowledge the issue. Don't know if he missed the post or what.

• John Vanderbeck
• http://www.johnvanderbeck.com

On Sat, Mar 7, 2015 at 9:58 AM, 6forty [email protected] wrote:

Disabling TR's texture unloading fixes the contract issues for me.

—
Reply to this email directly or view it on GitHub
#24 (comment).

[nanoblack]

I haven't seen sarbian's posts but I have seen a few others mention contracts being broken by TR, and that Shaw can't reproduce it. It doesn't seem to be TR itself, but TR + SXT.

With TR's default config and SXT installed I get the "Texture 'SXT/Agencies/KDB' is not readable" exception. That seems to completely break the fragile contracts system, since I also get a number of exceptions from ContractConfigurator failing to add SCANSat contracts and I get all those space center scene switching issues that happen when contracts in a savegame are broke.

Adding "^SXT/Agencies/" to TR's keepLoaded list or setting isUnloadingEnabled to never fixes all of the above for me. I've been able to reliably reproduce the issue and my solution on linux. Don't know how relevant that is, but mentioning it since @NathanKell did above.

[jwvanderbeck]

Here is sarbian's post:
http://forum.kerbalspaceprogram.com/threads/107471-0-90-TextureReplacer-2-2-5-%2830-1-2015%29?p=1756570&viewfull=1#post1756570

It has nothing to do with any specific mod, it has to do with TR failing to
handle the D3D error. Yes you can get around the error by manually
excluding mods, so that the errors don't happen in the first place,

• John Vanderbeck
• http://www.johnvanderbeck.com

On Sat, Mar 7, 2015 at 11:12 AM, 6forty [email protected] wrote:

I haven't seen sarbian's posts but I have seen a few others mention
contracts being broken by TR, and that Shaw can't reproduce it. It doesn't
seem to be TR itself, but TR + SXT.

With TR's default config and SXT installed I get the "Texture
'SXT/Agencies/KDB' is not readable" exception. That seems to completely
break the fragile contracts system, since I also get a number of exceptions
from ContractConfigurator failing to add SCANSat contracts and I get all
those space center scene switching issues that happen when contracts in a
savegame are broke.

Adding "^SXT/Agencies/" to TR's keepLoaded list or setting
isUnloadingEnabled to never fixes all of the above for me. I've been able
to reliably reproduce the issue and my solution on linux. Don't know how
relevant that is, but mentioning it since @NathanKell
https://github.com/NathanKell did above.

—
Reply to this email directly or view it on GitHub
#24 (comment).

[NathanKell]

@jwvanderbeck as I said above there are two issues. As @6FortY points out the most RP-0-relevant one has been found and there's a fix, but the one you are talking about (which is not that one) remains.

[jwvanderbeck]

Well my point is that I think all of them can be "fixed" with proper
exclusions. But end users don't know this, nor do it. Which is why it
really needs to be handled properly by TR. No matter how we look at it
though there isn't much we can do.

• John Vanderbeck
• http://www.johnvanderbeck.com

On Sat, Mar 7, 2015 at 11:44 AM, NathanKell [email protected]
wrote:

@jwvanderbeck https://github.com/jwvanderbeck as I said above there are
two issues. As @6FortY https://github.com/6forty points out the most
RP-0-relevant one has been found and there's a fix, but the one you are
talking about (which is not that one) remains.

—
Reply to this email directly or view it on GitHub
#24 (comment).

[Bornholio]

Close this? Fixed long ago