Giter Site home page Giter Site logo

Update Fuzz Tests about kactl HOT 3 CLOSED

Chillee avatar Chillee commented on August 19, 2024
Update Fuzz Tests

from kactl.

Comments (3)

simonlindholm avatar simonlindholm commented on August 19, 2024

fast-delaunay.cpp (Not sure what's going on here... Is looks like # is test failures? That seems bad? It also floods my screen for output and takes forever. @simonlindholm ?).

# indicates that the test case was skipped due to duplicate points. There used to be , and ? markers for skipping tests for concyclicity/colinearity reasons as well, but those were commented-out with the latest Delaunay implementation which handles that. The points of the markers are to indicate a) that the test hasn't hung, b) approximate performance, c) that the test doesn't skip all cases, in a simple-to-implement way. They could probably be removed/commented out. Real test failures terminate the test.

As for the performance, well, more tests is good, right? Delaunay triangulation probably has a lot of special cases. But a fast/slow mode for that test would likely be a good thing.

2sat.cpp (Running main1() causes a segfault. Don't know whether it's because it's an outdated test or 2Sat has problems).

You're just hitting the stack limit.

from kactl.

Chillee avatar Chillee commented on August 19, 2024

Got it. Updated the issue in response.

2sat.cpp has some other issues. Namely, it's unclear to me what the tests are meant to output. For main1, 0 and 1 respectively. For main2, I can reason about the correct output. For main3, it looks like it should be outputting something ~95/100?

from kactl.

simonlindholm avatar simonlindholm commented on August 19, 2024

Right. You can comment out the printouts, those were mainly just for some intuition about how random 2-sat behaves. It's still asserting correctness.

from kactl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.