`PhpdocArrayStyleFixer` breaks PHPStorm-friendly traversable info

[kubawerlos]

`PhpdocArrayStyleFixer` breaks PHPStorm-friendly traversable info

[kubawerlos]

I'm confused why Collection|Foo[] is ambiguous (@ondrejmirtes is there any reason for such behavior?).
If one means a collection of objects why not simply use Collection<Foo>?

In PSR-5 [] is clearly defined as an array.

[ondrejmirtes]

Collection|Foo[] was popular back in the old days (think when NetBeans was the popular IDE) to mean Collection of Foo. So when PHPStan sees Collection|Foo[] and Collection is iterable, it does this.

Yeah, I'd like to not use this syntax anymore, but it's out there so PHPStan needs to understand this. To disambiguate it to mean "Collection or array", you can do Collection|array<Foo>.

It's described in the docs: https://phpstan.org/writing-php-code/phpdoc-types#iterables

[Wirone]

FYI: it was fixed in PHPStorm, I just checked on our codebase and there's valid autocomplete even after removing |Foo[] part. In our case we need to get rid of that legacy union type, so feel free to close this if you don't feel the need to provide such improvement 😉.

For now we have clone of your fixer with additional condition in the fixType() method:

// CHANGED: Do not touch complex types (e.g. `FooCollection|Foo[]`)
if (strpos($type, '|') !== false || strpos($type, '&') !== false) {
    return $type;
}

[kubawerlos]

Based on Ondrej's answer (and the fact that doing this will be tricky) let's not add support to exclude this scenario.