Giter Site home page Giter Site logo

handle simple enum types about kopium HOT 2 CLOSED

clux avatar clux commented on May 30, 2024
handle simple enum types

from kopium.

Comments (2)

alex-hunt-materialize avatar alex-hunt-materialize commented on May 30, 2024 1

Currently, I think we will error out, or omit enum parts of the schema.

Current behavior is to omit the enum part, and just treat it (in this example) as a simple String.

operator:
  enum:
  - In
  - NotIn
  - Exists
  - DoesNotExist
  type: string

becomes

pub operator: String,

A complete example can be found in the Linkerd 2.11 ServerAuthorization and Server CRDs (at least, as generated by their helm chart). I've saved the generated one in a gist, since I can't find an official download of a pre-generated CRD.
https://gist.github.com/alex-hunt-materialize/2743b1e2e58a49c4df0a11ecb39f46ab

These CRDs actually have several issues with the current generation, but I'll make separate issues for those.

from kopium.

clux avatar clux commented on May 30, 2024 1

Handling simple enum's like this turns out not to be particularly difficult. Provided there are no other cases that can set type to something else or leave it unset, this will be handled by #65. The more complex enums using oneOf is going to be more complicated (and will open some follow-ups), but will try to use the ServiceMonitor as acceptance criteria for this issue as it only has a simple enum.

from kopium.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.