Giter Site home page Giter Site logo

Comments (4)

carlory avatar carlory commented on June 10, 2024

/assign

from csi-driver-host-path.

carlory avatar carlory commented on June 10, 2024

I raise a pr but I don't know which attributes of a linux directory or device can be mutable? Can you give me some guide?

@sunnylovestiramisu @msau42

from csi-driver-host-path.

sunnylovestiramisu avatar sunnylovestiramisu commented on June 10, 2024

@carlory We talked about this at the CSI meeting today:

  1. We should look at https://github.com/kubernetes-csi/csi-driver-host-path/blob/master/pkg/state/state.go#L39 and see if there is any attributes that can be modified first(so far none of them can be modified IMO)
  2. Since the host path driver has two modes, we can add fake params in the mock client for modify volume, and then add unit tests to verify the change

from csi-driver-host-path.

sunnylovestiramisu avatar sunnylovestiramisu commented on June 10, 2024

From the comment in resizer: kubernetes-csi/external-resizer#351 (review)

The test cases we should cover with the mock client:

  1. When a VAC is applied to a PVC that was created before VAC feature existed.
  2. When VAC is applied to a PVC that was provisioned without any VAC (but after the feature existed in k8s and external-provisioner).
  3. When VAC is applied rapidly to a PVC before previous VAC had a chance to be applied completely.
  4. When both VAC and volume expansion change is performed at the same time.
  5. When both VAC and volume expansion change is performed at the same time, but VAC change keeps failing. Can volume still be expanded for new size?

from csi-driver-host-path.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.