Run more automated checks on cluster-api repo

[kubernetes-sigs]

Run more automated checks on cluster-api repo

[rsdcastro]

From @vaibhavsingh97 on February 16, 2018 12:15

Hi @krousey Can I take this issue? Any resources to fix this issue will be a great help :)

[rsdcastro]

From @krousey on February 16, 2018 17:42

@vaibhavsingh97 Sure! go vet and go fmt would be the easiest to start with, and they cover areas that aren't someone protected against by our current CI build and test.

I started a CI scripts directory here: https://github.com/kubernetes/kube-deploy/tree/master/scripts

Here are the PRs I submitted to turn on build and testing in CI and on PRs. Hopefully that will be instructive enough.

• kubernetes-retired/kube-deploy#584
• kubernetes-retired/kube-deploy#590
• kubernetes/test-infra#6761
• kubernetes/test-infra#6787
• kubernetes/test-infra#6792

Also, if you're running the scripts locally, I would recommend Go 1.9+ because they changed the way go tools handle the vendor directory to make it easier.

[roberthbailey]

@alvaroaleman did some of this in #589 and go vet is taken care of by the migration to kubebuilder.

[alvaroaleman]

@roberthbailey Regarding a Verify vendor dependencies are correct, there is still kubernetes/test-infra#9874 open.

When that is done I think the only missing part is the gofmt, we execute it in the presubmits but we don't fail a presubmit if it creates a diff

[justinsb]

Spell checkers would probably be handy - other k repos use misspell https://github.com/kubernetes/kubernetes/blob/master/hack/verify-spelling.sh

misspell is good at not having false positives, but only detects common misspellings. Other ones suggested in the meeting: aspell

[dlipovetsky]

Some linting would be useful. For example, to ensure errors aren't ignored.

@randomvariable suggested the "meta-linter" https://github.com/golangci/golangci-lint, which is currently used in the AWS provider.

[egopher]

@roberthbailey @rsdcastro Will take this. I think meta-linter is a good approach for that as it's runs a lot of checks including go vet, fmt.

[randomvariable]

@egopher

Will take this.

Cool.

From the AWS set up, there's this in our build.bazel:
https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/master/BUILD.bazel#L67

and https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/master/.golangci.yml defines our current linters.

I tried a whole bunch of linters, this came out best because it's a singularly compiled binary, and some of the other metalinters shell out, and it's difficult to control versioning and installation of dependencies in a CI context when they do that.

[vincepri]

I think now that we have vendor and bazel verification, this issue is almost there to be closed. The only thing missing is gometalinter.