Comments (8)
We haven't gone through the exercise of using builtin CRD validation. The defaults are provider specific. See: https://github.com/aws/karpenter/blob/main/pkg/apis/v1alpha5/provisioner.go#L45. I'd be curious to see if you could replace the validation webhooks.
from karpenter.
We haven't gone through the exercise of using builtin CRD validation.
@ellistarn can you please elaborate on that?
It is much easier to add some fields to the CRD schema than writing additional code to validate it.
For example the following code could be easily replaced with a required: ["evictionSoftGracePeriod"]
block within the schema.
I believe the defaulting webhook could also be avoided by adding default
fields within the CRD schema.
from karpenter.
Interesting ideas. Would you be interested in contributing this?
from karpenter.
@ellistarn sure.
Should I open a PR for the CRDs changes?
from karpenter.
Sure thing!
from karpenter.
Labeled for closure due to inactivity in 10 days.
from karpenter.
Labeled for closure due to inactivity in 10 days.
from karpenter.
Kubernetes supports CEL for CRD validation. We should investigate this along with the other validations that are supported natively by the Open API specs (like defaults, minimum, maximums, etc.)
from karpenter.
Related Issues (20)
- Make consolidation configurable HOT 2
- Prometheus metric karpenter_nodeclaims_created does not contain capacity_type label HOT 3
- Failing to provision EC2 node even though matching EC2 node type exists HOT 9
- NodePool Limit by dollars HOT 6
- Support Nvidia GPU Feature Discovery HOT 9
- Test HOT 1
- Test
- Test
- Test
- Should ClusterState be leveraged by the cloudprovider gc controllers? HOT 1
- Karpenter Install 0.36.0 CrashLoopBackOff
- Document the way the Kubernetes scheduler mode impacts Karpenter HOT 3
- Test
- test HOT 7
- Dynamic Resource Allocation HOT 3
- Zonal Volume Requirements Break Topology Spread Constraints HOT 2
- Improve Disruption Candidacy Documentation HOT 2
- Karpenter is massively consolidate nodes on version 0.31.4 HOT 6
- test: run scale tests and automated e2e testing in KwoK HOT 3
- Karpenter consolidating nodes that are required by podAntiAffinity, then recreates them HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from karpenter.