Allow installing without sha256 when using --manifest-url

[grosser]

Allow installing without sha256 when using --manifest-url

[ahmetb]

-manifest-url/-manifest-file is largely intended for testing manifests; not for distribution. You can still ship an executable to your colleagues and they can put it on their PATH?

We could change the scope and behavior here but I suspect it won't be a major UX improvement for a broad audience.

[grosser]

If it's intended for testing then allowing not using a Sha would make that even easier ?

…

On Tue, Dec 26, 2023, 6:11 PM Ahmet Alp Balkan ***@***.***> wrote: -manifest-url/-manifest-file is largely intended for testing manifests; not for distribution. You can still ship an executable to your colleagues and they can put it on their PATH? We could change the scope and behavior here but I suspect it won't be a major UX improvement for a broad audience. — Reply to this email directly, view it on GitHub <#846 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACYZYDICD4MZQLQUVU6T3YLN7WTAVCNFSM6AAAAABBDYNU6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZHA4DCNBUGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[ahmetb]

It's used for testing the correctness of the manifest locally without sending a PR, so sha256 validation is part of that.

[grosser]

yeah, but allowing it to be missing could be nice if I want to test everything else except the sha also allows pointing to a generic `latest.zip`

…

On Tue, Dec 26, 2023 at 9:45 PM Ahmet Alp Balkan ***@***.***> wrote: It's used for testing the correctness of the manifest locally without sending a PR, so sha256 validation is part of that. — Reply to this email directly, view it on GitHub <#846 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACYZ4FRM56CXANGNHTXETYLOYW3AVCNFSM6AAAAABBDYNU6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZHE3TAMBTGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>