Make create resource copy create a controller struct that has InjectArguments instead of individual fields

[kubernetes-sigs]

Make create resource copy create a controller struct that has InjectArguments instead of individual fields

[pwittrock]

@fanzhangio Re assigning to @lichuqiang since you have a few issues assigned to already

[lichuqiang]

Talked with @pwittrock . Personally I think it more friendly to keep the fileds as is today:

// +kubebuilder:controller:group=bar,version=v1alpha1,kind=Foo,resource=foos
type FooController struct {
    // INSERT ADDITIONAL FIELDS HERE
    fooLister barv1alpha1lister.FooLister
    fooclient barv1alpha1client.BarV1alpha1Interface
    // recorder is an event recorder for recording Event resources to the
    // Kubernetes API.
    foorecorder record.EventRecorder
}

than replace with InjectArguments:

// +kubebuilder:controller:group=bar,version=v1alpha1,kind=Foo,resource=foos
type FooController struct {
    arguments args.InjectArgs
}

From the view of a user, I think it a common case for developers to make use of lister/clients in the reconcile func, and it would be more friendly to have them initialized in the controller.
And if they don't need some of the fields, just remove them. The cost of deleting is lower than adding.

Maybe we need more feedback to decide how it should looks like

[pwittrock]

Closing this for now