Comments (6)
Closing this, as we are doing out of tree
from kubetest2.
@amwat thoughts?
from kubetest2.
I don't have any specific objections against it (especially since we clarified re: dependencies.)
Although some things to consider, having it in-tree means it would be coupled with the release lifecycle of this repo (eventually), and would expect at the very least to have community CI running against it.
Note that kubetest2 supports out of tree deployers, have you considered that?
most other providers opted to go that route ^
kops: https://github.com/kubernetes/kops/tree/9dc910bdac92468793b4e4eff9b75524044291bd/tests/e2e/kubetest2-kops
eks: https://github.com/aws/aws-k8s-tester
cluster-api: #48
from kubetest2.
I think out of tree is a great idea. Where is the interface defined?
from kubetest2.
types are defined here: https://github.com/kubernetes-sigs/kubetest2/blob/master/pkg/types/types.go#L70-L82
Although, the actual contract with kubetest2 is just naming the binary kubetest2-*
and calling into the shim app.Main()
https://github.com/kubernetes/kops/blob/9dc910bdac92468793b4e4eff9b75524044291bd/tests/e2e/kubetest2-kops/main.go#L26
from kubetest2.
Really happy to see this :)
definitely reach out if you run into any core feature requests that would be helpful for all deployers.
from kubetest2.
Related Issues (20)
- Kubetest2 doesn not down on ginkgo failures HOT 1
- Implement minikube deployer HOT 7
- Implement AKS deployer HOT 5
- Support GCE PD testing HOT 8
- kubetest2-ginko tester overwrites local e2e.test HOT 6
- Ginkgo v2 flag changes break testing older k8s versions HOT 3
- Kubetest2 should support ginkgov2 for 1.25+ and ginkgov1 for 1.24- HOT 1
- Remove dependence on boskos and test-infra HOT 6
- Unsafe concurrent use of bytes.Buffer HOT 2
- Unable to go install kubetest2 with go 1.17
- Document kubetest2 deployers
- Stop building `k/cloud-provider-gcp` if all you are doing is building k8s clusters HOT 4
- Is gsutil package required to run kubetest2? HOT 2
- Stuck at the beginning HOT 5
- Clarify purpose of end-to-end tests HOT 4
- --flake-attempts flag need not be removed from ginkgo tester HOT 3
- How to narrow down target test cases HOT 2
- Writing custom tests HOT 2
- Junit report format is not correct HOT 2
- Problem with passing the provider to the tests HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kubetest2.