Giter Site home page Giter Site logo

Comments (6)

chrislovecnm avatar chrislovecnm commented on June 30, 2024 1

Closing this, as we are doing out of tree

from kubetest2.

chrislovecnm avatar chrislovecnm commented on June 30, 2024

@amwat thoughts?

from kubetest2.

amwat avatar amwat commented on June 30, 2024

I don't have any specific objections against it (especially since we clarified re: dependencies.)

Although some things to consider, having it in-tree means it would be coupled with the release lifecycle of this repo (eventually), and would expect at the very least to have community CI running against it.

Note that kubetest2 supports out of tree deployers, have you considered that?
most other providers opted to go that route ^

kops: https://github.com/kubernetes/kops/tree/9dc910bdac92468793b4e4eff9b75524044291bd/tests/e2e/kubetest2-kops
eks: https://github.com/aws/aws-k8s-tester
cluster-api: #48

from kubetest2.

chrislovecnm avatar chrislovecnm commented on June 30, 2024

I think out of tree is a great idea. Where is the interface defined?

from kubetest2.

amwat avatar amwat commented on June 30, 2024

types are defined here: https://github.com/kubernetes-sigs/kubetest2/blob/master/pkg/types/types.go#L70-L82

Although, the actual contract with kubetest2 is just naming the binary kubetest2-* and calling into the shim app.Main() https://github.com/kubernetes/kops/blob/9dc910bdac92468793b4e4eff9b75524044291bd/tests/e2e/kubetest2-kops/main.go#L26

from kubetest2.

amwat avatar amwat commented on June 30, 2024

Really happy to see this :)
definitely reach out if you run into any core feature requests that would be helpful for all deployers.

from kubetest2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.