Giter Site home page Giter Site logo

Comments (3)

amwat avatar amwat commented on August 9, 2024

I don't have any strong objections. IIRC I don't think there was a specific reason for it to be named under sub directory that way. That being said I'm not sure if anything should assume that all generated artifacts would be in the top-level directory in the first place. But if perfdash is expecting in such a way I think that's a sane default.

I think we should solve it by doing both i.e. change the default to be top-level $ARTIFACTS and also expose the flag on the --report-dir clusterloader2 tester.

/triage accepted
/priority important-soon

from kubetest2.

piyushgupta1551 avatar piyushgupta1551 commented on August 9, 2024

Tx @amwat . Should I go ahead and raise the PR for these changes? Will remove the clusterloader2 folder name (make $ARTIFACTS folder as default) and will enable --report-dir as an arg to the tester.

from kubetest2.

amwat avatar amwat commented on August 9, 2024

That sounds great! Thank you

from kubetest2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.