Comments (3)
I don't have any strong objections. IIRC I don't think there was a specific reason for it to be named under sub directory that way. That being said I'm not sure if anything should assume that all generated artifacts would be in the top-level directory in the first place. But if perfdash is expecting in such a way I think that's a sane default.
I think we should solve it by doing both i.e. change the default to be top-level $ARTIFACTS and also expose the flag on the --report-dir
clusterloader2 tester.
/triage accepted
/priority important-soon
from kubetest2.
Tx @amwat . Should I go ahead and raise the PR for these changes? Will remove the clusterloader2 folder name (make $ARTIFACTS folder as default) and will enable --report-dir as an arg to the tester.
from kubetest2.
That sounds great! Thank you
from kubetest2.
Related Issues (20)
- --use-built-binaries for tests doesn't work with kind deployer HOT 7
- How to set the number of worker nodes while creating a test cluster with kind deployer? HOT 1
- Kubetest2 doesn not down on ginkgo failures HOT 1
- Implement minikube deployer HOT 7
- Implement AKS deployer HOT 5
- Support GCE PD testing HOT 8
- kubetest2-ginko tester overwrites local e2e.test HOT 6
- Ginkgo v2 flag changes break testing older k8s versions HOT 3
- Kubetest2 should support ginkgov2 for 1.25+ and ginkgov1 for 1.24- HOT 1
- Remove dependence on boskos and test-infra HOT 6
- Unsafe concurrent use of bytes.Buffer HOT 2
- Unable to go install kubetest2 with go 1.17
- Document kubetest2 deployers
- Stop building `k/cloud-provider-gcp` if all you are doing is building k8s clusters HOT 4
- Is gsutil package required to run kubetest2? HOT 2
- Stuck at the beginning HOT 5
- Clarify purpose of end-to-end tests HOT 4
- --flake-attempts flag need not be removed from ginkgo tester HOT 3
- How to narrow down target test cases HOT 2
- Writing custom tests HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kubetest2.