Giter Site home page Giter Site logo

Comments (4)

BenTheElder avatar BenTheElder commented on August 9, 2024 3

imho kubetest2 should avoid taking on many dependencies in the core, after your PR it's pretty nice at:

kubetest2/go.mod

Lines 5 to 12 in ef32b5b

require (
github.com/octago/sflags v0.2.0
github.com/pkg/errors v0.9.1
github.com/spf13/cobra v1.0.0
github.com/spf13/pflag v1.0.5
k8s.io/klog v1.0.0
sigs.k8s.io/boskos v0.0.0-20200710214748-f5935686c7fc
)

If any of the in-tree sample deployers want non-trivial dependencies for their own use, we should probably make them pull that into a separate binary / module one way or another to avoid that polluting the core package.

I would hope that kubestest2-kops could e.g. shell out to kops and be in-tree without any additional dependencies, but if kops wants to import kops code inside kubetest2-kops then we should probably put it in the kops repo.
The shim / binary-plugin style mechanism is intended to make this viable.

from kubetest2.

amwat avatar amwat commented on August 9, 2024

That is the intention :) Ideally you can implement your own deployer out of tree and still use the end-to-end flow as long as the deployers and tester are named correctly.

from kubetest2.

k8s-ci-robot avatar k8s-ci-robot commented on August 9, 2024

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from kubetest2.

BenTheElder avatar BenTheElder commented on August 9, 2024

The answer for now is: they are in another repo. https://github.com/kubernetes/kops/tree/9dc910bdac92468793b4e4eff9b75524044291bd/tests/e2e/kubetest2-kops

from kubetest2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.