Don't extract e2e.test and ginkgo binary into artifacts.BaseDir()

[kubernetes-sigs]

Don't extract e2e.test and ginkgo binary into artifacts.BaseDir()

[mkumatag]

location:

kubetest2/pkg/testers/ginkgo/package.go

Lines 96 to 97 in a964c23

	t.e2eTestPath = filepath.Join(artifacts.BaseDir(), "e2e.test")
	t.ginkgoPath = filepath.Join(artifacts.BaseDir(), "ginkgo")

[amwat]

I could see both sides here, it might be useful for someone while debugging to know exactly what binary was used.
But agree that it should be intentional, and configurable.

In general, we want to add a way where deployer/testers can choose to distinguish the artifacts used during the run vs the artifacts that the deployer/tests want to upload.

[mkumatag]

I could see both sides here, it might be useful for someone while debugging to know exactly what binary was used.
But agree that it should be intentional, and configurable.

In general, we want to add a way where deployer/testers can choose to distinguish the artifacts used during the run vs the artifacts that the deployer/tests want to upload.

Agree for somecase it will be helpful to collect as artifacts but in case of downloading or using these binaries from some other repository is very costly, not everyone can afford that default feature. As you mentioned let's think about putting it somewhere else so that artifact does not collect it.

[amwat]

This is fairly similar to #98 let's track it there.

Once that is fixed, default would be RunDir() (so no upload) and we can add functionality to allow optionally uploading (by copying them back to artifacts.BaseDir())

/cc @justinsb

/close

[k8s-ci-robot]

@amwat: Closing this issue.

In response to this:

This is fairly similar to #98 let's track it there.

Once that is fixed, default would be RunDir() (so no upload) and we can add functionality to allow optionally uploading (by copying them back to artifacts.BaseDir())

/cc @justinsb

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.