Giter Site home page Giter Site logo

Comments (10)

consideRatio avatar consideRatio commented on May 18, 2024 1

What about removing them, adding an instruction on how to generate them with helm template into an output dir? It can be a one liner to do so using the --repo flag.

I currently dont see a big enough value for an end user to have these generated in the repo. I imagine they will lead to some confusion, maintenance needs, and additional support questions and complexity.

from nfs-ganesha-server-and-external-provisioner.

kvaps avatar kvaps commented on May 18, 2024 1

I suppose someone can continue using them as a library for his jsonnet/kustomize project, but they are definitely not maintained, so such users can just hold on specific commit.

Let's try removing them, if there will be any issues, we can consider the solution later.

from nfs-ganesha-server-and-external-provisioner.

afbjorklund avatar afbjorklund commented on May 18, 2024

They seemed to be working still (like they did before the move*), it was mostly the image location that was outdated...

There is also no clear separation in the instructions where the "installation" ends and where the "usage" begins:

  • deployment.yaml
  • rbac.yaml
  • class.yaml
  • claim.yaml
  • write-pod.yaml

Preferrably there would be an all-in-one, so that one could have an external NFS storage provisioner as a one-liner ?

(my use case is mostly for education and very simple clusters, when trying to move on from HostPath to using PV)

https://github.com/kubernetes-sigs/nfs-ganesha-server-and-external-provisioner#quickstart

from nfs-ganesha-server-and-external-provisioner.

k8s-triage-robot avatar k8s-triage-robot commented on May 18, 2024

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

from nfs-ganesha-server-and-external-provisioner.

k8s-triage-robot avatar k8s-triage-robot commented on May 18, 2024

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

from nfs-ganesha-server-and-external-provisioner.

kvaps avatar kvaps commented on May 18, 2024

/remove-lifecycle rotten

No, those manifests were written manually.

I think the best option would be to have them generated from the helm template command.
We need to add CI job for /charts/nfs-server-provisioner to run on every PR and perform:

  • Check if chart version bumped
  • Check if manifest is generated from the latest chart version

from nfs-ganesha-server-and-external-provisioner.

k8s-triage-robot avatar k8s-triage-robot commented on May 18, 2024

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

from nfs-ganesha-server-and-external-provisioner.

k8s-triage-robot avatar k8s-triage-robot commented on May 18, 2024

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

from nfs-ganesha-server-and-external-provisioner.

k8s-triage-robot avatar k8s-triage-robot commented on May 18, 2024

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

from nfs-ganesha-server-and-external-provisioner.

k8s-ci-robot avatar k8s-ci-robot commented on May 18, 2024

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from nfs-ganesha-server-and-external-provisioner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.