Comments (6)
This issue is currently awaiting triage.
If the repository mantainers determine this is a relevant issue, they will accept it by applying the triage/accepted
label and provide further guidance.
The triage/accepted
label can be added by org members by writing /triage accepted
in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from cloud-provider-gcp.
The client-go dependency is particularly painful because it doesn't follow semantic versioning and there are occasionally breaking changes across minor version bumps.
Can you give me an example when this happened?
Client-go may have bugs but breaking changes should not be normal?
to use their own client
Which client is this? Just curious
from cloud-provider-gcp.
Can you give me an example when this happened?
kubernetes-sigs/controller-runtime#2222. This required controller-runtime to be updated (cilium/cilium@3828143), which ended up being a significant change.
Which client is this? Just curious
For our use-case, just an older version of client-go. I was also thinking of controller-runtime
client (https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/client) but I guess it just uses client-go
under the hood.
from cloud-provider-gcp.
Having a Go module specifically for the CRD types would eliminate client-go as a dependency and reduce some of the dependency hell.
client-go is a dependency and is always going to be, a common mistake is leaving it pinned in an older versions, this is accidentally incentivizing doing the right thing, that is keeping the dependencies up to date
from cloud-provider-gcp.
Ack, this was mainly an issue because we were introducing new dependencies (on k8s 1.27 libs) to older stable branches (on k8s 1.25 libs). We have a workaround for now, and a strategy for avoiding this situation going forward. So, I think we can close this for now.
from cloud-provider-gcp.
if this turns out to be more problematic we'll revisit
from cloud-provider-gcp.
Related Issues (20)
- TEST ISSUE 2 HOT 2
- go.sum is out of sync (requires go 1.20?) HOT 6
- Remove Bazel from cloud-provider-gcp and use make to build it HOT 4
- Cloud.InstanceID() does not actually return a unique Instance ID HOT 16
- The networking logic to detect preempted VMs based on the node.Spec.PodCIDR values is not generalizable HOT 2
- The cloud-controller-manager relies on the `system:serviceaccount:kube-system:cloud-provider` principal which is deprecated HOT 3
- Internal Loadbalancers don't work if a cluster is using custom mode subnets HOT 7
- The worker number for controllers should be configurable HOT 5
- Error: failed to get instance metadata HOT 9
- GNP controller does not log API errors HOT 5
- Remove backends from backend services before updating HOT 7
- RFE: Enable logging via service annotations for load balancer backends HOT 7
- `gke-gcloud-auth-plugin`: Support passing credentials via a specific JSON filepath HOT 3
- Add DevContainer Definitons For One-Click Dev Env Setup HOT 6
- Working example doc HOT 4
- CAPG: Upstream CCM manifest doesn't work HOT 7
- Create documentation for setting up and using the out-of-tree provider HOT 7
- Failure when trying to run kubetest2 --up with gcp in non-legacy mode HOT 2
- Cluster self healing have not works with Cilium CNI HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cloud-provider-gcp.