Make `crd/apis` a Go module?

[akhilles]

Make `crd/apis` a Go module?

[k8s-ci-robot]

This issue is currently awaiting triage.

If the repository mantainers determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aojea]

The client-go dependency is particularly painful because it doesn't follow semantic versioning and there are occasionally breaking changes across minor version bumps.

Can you give me an example when this happened?

Client-go may have bugs but breaking changes should not be normal?

to use their own client

Which client is this? Just curious

[akhilles]

Can you give me an example when this happened?

kubernetes-sigs/controller-runtime#2222. This required controller-runtime to be updated (cilium/cilium@3828143), which ended up being a significant change.

Which client is this? Just curious

For our use-case, just an older version of client-go. I was also thinking of controller-runtime client (https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/client) but I guess it just uses client-go under the hood.

[aojea]

Having a Go module specifically for the CRD types would eliminate client-go as a dependency and reduce some of the dependency hell.

client-go is a dependency and is always going to be, a common mistake is leaving it pinned in an older versions, this is accidentally incentivizing doing the right thing, that is keeping the dependencies up to date

[akhilles]

Ack, this was mainly an issue because we were introducing new dependencies (on k8s 1.27 libs) to older stable branches (on k8s 1.25 libs). We have a workaround for now, and a strategy for avoiding this situation going forward. So, I think we can close this for now.

[aojea]

if this turns out to be more problematic we'll revisit