GeoIP2 auto_reload doesn't work

[isniukArte]

GeoIP2 auto_reload doesn't work

[longwuyuan]

• I can reproduce this with value set to 2, "2" or 2m
• Wait for comments from @rikatz @tao12345666333
  cc @cpanato

/triage accepted
/priority important-longterm

I suspect that geoip1 was accepting int value but i think upstream changed and that geoip2 module expects "time" value like "2m", as per this https://github.com/leev/ngx_http_geoip2_module#example-usage (like auto_reload 2m;)

[longwuyuan]

/assign

[longwuyuan]

@isniukArte did you use geoip1 earlier ?

[longwuyuan]

@rikatz @tao12345666333 @cpanato @strongjz The nginx.tmpl in the image is not even containing the if condition for the reload value

But the src of the base image has the if condition

ingress-nginx/rootfs/etc/nginx/template/nginx.tmpl

Line 204 in 4e11074

auto_reload {{ $cfg.GeoIP2AutoReloadMinutes }}m;

So this is confirmed a bug. The annotation https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/configmap/#geoip2-autoreload-in-minutes is definitely broken

/priority important-soon

[longwuyuan]

/remove-priority important-longterm

[longwuyuan]

ok, the root-cause is clear now. The PR #11079 that introduces that if condition for the reload time is not cherry-picked into the branch release-1.10, from which this controller version was released

@Gacko @strongjz @rikatz @tao12345666333 @cpanato Please comment on chery-picking PR #11079 (or using another way) to pull these changes to the branch release-1.10

[isniukArte]

@isniukArte did you use geoip1 earlier ?

Nope, but I think it already doesn't matter.

[longwuyuan]

ok