Giter Site home page Giter Site logo

Comments (3)

hasheddan avatar hasheddan commented on August 15, 2024

Pinging a few relevant folks to get feedback on proposal :) @apelisse @sttts I would love to get this opened and merged quickly if y'all are on board 👍🏻 Thanks for the work y'all do here!

from kube-openapi.

apelisse avatar apelisse commented on August 15, 2024

I'd love to see and comment on a PR for that, I agree that the JSONPath is more consistent with the general consensus and is consistent with what @kevindelgado is doing for return strict decoding errors.

While reading your description and the code, it's not clear to me why we're not creating a new validator for each individual child rather than do what you suggest in 1.? Happy to have this discussion on the pull-request though.

from kube-openapi.

hasheddan avatar hasheddan commented on August 15, 2024

@apelisse I think there may be some confusion around my terminology for parent and child validators (given the recursive nature of the validation we are performing here). What I am actually referring to is the SchemaValidator (parent) and the specific type validators it contains (children). I have opened a PR with fixes here: #273

Looking forward to your review!

from kube-openapi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.