Giter Site home page Giter Site logo

Comments (16)

brancz avatar brancz commented on August 27, 2024 5

While I'm still not aware that someone is working on this, the things I mentioned before don't apply anymore. The k8s.io/client-go dependency has been updated and backward-compatibility is not an issue anymore as those collectors can now be disabled when necessary.

from kube-state-metrics.

brancz avatar brancz commented on August 27, 2024 4

Closing here as #151 is merged.

from kube-state-metrics.

brancz avatar brancz commented on August 27, 2024 1

He mentioned that they're planning to release generators to generate the clients for deprecated APIs .. that's basically what https://github.com/ericchiang/k8s already does, however it is currently lacking the informer functionality that we heavily rely on.

That said, what I meant is that we can't wait for the generators to be released, and for now we'll have to move forward with what we have, which means whatever is the latest version of each resource. And if that causes problems for individual users, they'll have to turn off that collector via the available flags.

from kube-state-metrics.

brancz avatar brancz commented on August 27, 2024 1

We should do what we can get out of a 1.6 cluster, so aside from having to update client go this should be possible to be worked on.

from kube-state-metrics.

brancz avatar brancz commented on August 27, 2024

Definitely interesting! I am not aware of anyone working on this currently. A few caveats if you were to get started:

  • It will require an upgrade of the vendored k8s.io/client-go library, which is pretty painless, but necessary. I was thinking of doing this some time soon, but if someone wants to take a go at it go ahead. (I probably won't get started before the holidays)
  • It will need to be done in a backward compatible way, as we currently have compatibility down to 1.2 and it would be nice if we can keep that. What that would mean is that collection for StatefulSets is turned off if the cluster version is lower than 1.5.0.

from kube-state-metrics.

nvartolomei avatar nvartolomei commented on August 27, 2024

This is blocked by kubernetes/client-go#183

from kube-state-metrics.

nvartolomei avatar nvartolomei commented on August 27, 2024

@brancz looks like there is no easy way to support multiple kubernetes versions using a single client.

kubernetes/client-go#183

from kube-state-metrics.

brancz avatar brancz commented on August 27, 2024

I guess then we people will just have to disable the collector and that way we can provide backward compatibility on a best effort basis, but not for multiple versions of the same object. At least there is some light at the horizon, but it doesn't sound like we can wait for that.

from kube-state-metrics.

nvartolomei avatar nvartolomei commented on August 27, 2024

@brancz what light? Looks like there is only one proper solution, to have different kube-state-metrics releases to match kubernetes (api) versions.

There will be conflicts each time apis graduate or deprecated and deleted (from client-go too).

from kube-state-metrics.

devth avatar devth commented on August 27, 2024

Is this still blocked?

from kube-state-metrics.

blakebarnett avatar blakebarnett commented on August 27, 2024

Hoping #151 goes in and 0.6 gets released soon! Would love to have jobs/cronjob and statefulset metrics.

from kube-state-metrics.

stijndehaes avatar stijndehaes commented on August 27, 2024

@blakebarnett I was just about to mention my PR on this issue. I am also waiting for StatefulSet metrics. So I am hoping that someone reviews my PR as soon as possible

from kube-state-metrics.

brancz avatar brancz commented on August 27, 2024

I reviewed and merged #151, there is one more thing I would like to get into the next release, which is selecting which namespaces to gather the objects from. I don't think I'll get to implementing that before next week, but after that I'll do another release. It's coming! 🙂

from kube-state-metrics.

devth avatar devth commented on August 27, 2024

Shouldn't statefulset metrics have available_replicas, the same as deployments? It's not as useful to know the intended number of replicas in prom_kube_statefulset_replicas as it would be to know whether those replicas are actually up.

from kube-state-metrics.

stijndehaes avatar stijndehaes commented on August 27, 2024

You have kube_statefulset_status_replicas and kube_statefulset_replicas.
The first one is the available replicas and the second one is the intended replicas. Statefulsets work a bit differently under the hood that's why the naming is not exactly the same as with deployments

from kube-state-metrics.

brancz avatar brancz commented on August 27, 2024

The metric names are typically determined by the fields in the Kubernetes API objects.

from kube-state-metrics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.