Giter Site home page Giter Site logo

Comments (8)

vdavidoff avatar vdavidoff commented on July 24, 2024 2

I have started working on exposing Job metrics. I have a dev build working, I think, though it hasn't been thoroughly tested to ensure there are no edge cases (or cases simply unlike the state of my test clusters) where the code blows up. I haven't started on the unit tests, either. I'm about to start looking at CronJobs to see what can/should be exposed there.

Quite frankly I'm sort of hacking at this. It's going well but if anyone is interested in reviewing code and/or helping write the unit tests, that'd be swell. Otherwise I'll try to get it all done. I'm working here: https://github.com/vdavidoff/kube-state-metrics

from kube-state-metrics.

fcantournet avatar fcantournet commented on July 24, 2024 1

Might also be worth having the PodStatuses for Jobs ( for the number of failures )

from kube-state-metrics.

brancz avatar brancz commented on July 24, 2024 1

@vdavidoff feel free to open a PR already, that exactly the situation what they're for 🙂. Reviews aren't there to make anyone feel bad or unqualified, we can all learn from them and we can track progress a lot better. There is no need for it to be completely done, it's perfectly fine to be work in progress.

If you can't manage to finish the unit tests, but the rest of the implementation is more or less done, we may just pick it up from where you left off - no work is wasted work. Thanks a lot for your effort!

from kube-state-metrics.

brancz avatar brancz commented on July 24, 2024 1

Closed by #131

from kube-state-metrics.

jhorwit2 avatar jhorwit2 commented on July 24, 2024

Cronjobs are being promoted to beta in 1.6 kubernetes/enhancements#19

this would be super nice to have

from kube-state-metrics.

igniting avatar igniting commented on July 24, 2024

Is there any progress on this?

from kube-state-metrics.

brancz avatar brancz commented on July 24, 2024

I am currently not aware of anyone working on this, if anyone wants to grab it, go head! 🙂

from kube-state-metrics.

vdavidoff avatar vdavidoff commented on July 24, 2024

I have Job and CronJob metrics working. I think the metrics I'm exposing, and how I'm exposing them, makes sense, but feedback on that as well as coding choices etc. is most welcome. In fact I highly recommend it.

I can assure you that someone who is more familiar with the tests than I am will be much quicker at getting the _test files done. My plan is to do them as I have time, but I don't know how long that'll be, and I realize that nothing I have done will get merged until those are complete. Or, I assume that's the case, at least.

from kube-state-metrics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.