Giter Site home page Giter Site logo

Comments (23)

sttts avatar sttts commented on July 27, 2024 2

@spiffxp I wasn't aware that we link OWNERS files there. So of course the new repos belong into that file 👍

from org.

spiffxp avatar spiffxp commented on July 27, 2024 2

I chatted with @sttts offline, the repo descriptions have been changed

Just waiting for a sigs.yaml PR to close this out

from org.

sttts avatar sttts commented on July 27, 2024 1

@cblecker the KEP was approved which proposed these repos.

from org.

stewart-yu avatar stewart-yu commented on July 27, 2024 1

thanks, but seems no need to create repo for cloud-controller-manager now. @spiffxp 😀
/cc @sttts

from org.

sttts avatar sttts commented on July 27, 2024 1

thanks, but seems no need to create repo for cloud-controller-manager now.

@stewart-yu thanks for the correction. Yes, we keep those types in the cmd package because the future of the binary is not clear.

from org.

spiffxp avatar spiffxp commented on July 27, 2024 1

Having sig-arch own root and specialized sigs own different packages was one of the suggestions I made above. I have no strong preference other than an option get chosen. I will ask the sig-arch mailing list

from org.

cblecker avatar cblecker commented on July 27, 2024

@sttts Has sig-arch approved of new core repos? Was there a meeting agenda item or a mailing list thread where they do?

cc: @jdumars @bgrant0607

from org.

cblecker avatar cblecker commented on July 27, 2024

Looks like this is slated for discussion in sig-arch on Thursday
kubernetes/community#2627

from org.

sttts avatar sttts commented on July 27, 2024

@cblecker Sig-arch approved them: https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/kubernetes-sig-architecture/x_-L4dlwbeU/qwlEd64kBgAJ

from org.

spiffxp avatar spiffxp commented on July 27, 2024

from org.

spiffxp avatar spiffxp commented on July 27, 2024

/assign
I believe this is done but I'll leave this open to confirm since this is staging

from org.

spiffxp avatar spiffxp commented on July 27, 2024

It's also unclear to me whether/where these repos should fall in sigs.yaml?

from org.

GeorgeGuo2018 avatar GeorgeGuo2018 commented on July 27, 2024

https://github.com/kubernetes/kube-controller-manager
this repo is empty now, what should i do if my older projects referred package from this repo?
Any reply would be appreciated,thx.

from org.

sttts avatar sttts commented on July 27, 2024

this repo is empty now, what should i do if my older projects referred package from this repo?
Any reply would be appreciated,thx.

@GeorgeGuo2018 I will update github.com/kubernetes/publishing-bot and it will fill that repo.

Which "older projects" do you refer to?

from org.

sttts avatar sttts commented on July 27, 2024

@spiffxp we have the OWNERS files in there. Isn't that enough? Listing those repos in sigs.yaml in addition sounds equivalent.

from org.

sttts avatar sttts commented on July 27, 2024

@spiffxp as @stewart-yu correctly noted, cloud-controller-manager is not used. You can delete it again.

from org.

spiffxp avatar spiffxp commented on July 27, 2024

@sttts every other repo that comes out of staging is listed in sigs.yaml as belonging to a sig, egs:

sig-api-machinery has this entry

- name: universal-machinery # i.e., both client and server
      owners:
      - https://raw.githubusercontent.com/kubernetes/apimachinery/master/OWNERS
      - https://raw.githubusercontent.com/kubernetes/kubernetes/master/staging/src/k8s.io/apimachinery/OWNERS

sig-architecture has this entry

- name: api
      owners:
      - https://raw.githubusercontent.com/kubernetes/api/master/OWNERS
      - https://raw.githubusercontent.com/kubernetes/kubernetes/master/staging/src/k8s.io/api/OWNERS

I don't know if the intent is to move to a world where each component is owned by a different sig, eg:

  • sig-node owns kubelet
  • sig-network owns kube-proxy
  • sig-apps owns kube-controller-manager
  • sig-api-machinery owns kube-apiserver
  • sig-scheduling owns kube-scheduler

or, if sig-archtecture owns the root of each component, with individual sigs owning packages within (eg: sig-architecture owns api, but sig-apps owns the workload apis)

from org.

spiffxp avatar spiffxp commented on July 27, 2024

Current status:

  • I removed cloud-controller-manager
  • The other repos look to be synced by publishing-bot now
  • I have yet to confirm that the repos have been added to sigs.yaml

from org.

luxas avatar luxas commented on July 27, 2024

I don't know either whether we want the specialized SIG (e.g. node) to own all of the k8s.io/kubelet repo or if we want it to own e.g. pkg/ and cmd/ only?
That really dictates the structure of the sigs.yaml PR. Any preferences?

from org.

spiffxp avatar spiffxp commented on July 27, 2024

kubernetes-sig-arch@ thread

from org.

spiffxp avatar spiffxp commented on July 27, 2024

So far I have received two responses, both of which seem to suggest the sig-arch root / sig-foo subdirs approach.

from org.

luxas avatar luxas commented on July 27, 2024

The final piece of this was fixed with kubernetes/kubernetes#70453, closing
/close

from org.

k8s-ci-robot avatar k8s-ci-robot commented on July 27, 2024

@luxas: Closing this issue.

In response to this:

The final piece of this was fixed with kubernetes/kubernetes#70453, closing
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.