Giter Site home page Giter Site logo

Comments (2)

devdattakulkarni avatar devdattakulkarni commented on July 17, 2024

@mysterytony No, the comment is correct. What it is referring to is the line 330. In that 'Update' method is used. The comment is saying that, instead of using the 'Update' method, more accurate would be to use the 'UpdateStatus' method since it is only the Status of the Custom Resource that we want to update. 'UpdateStatus' will update only the status and nothing else. With 'Update' it is programmer's responsibility to ensure that only the Status fields are updated and not any part of the Spec, even accidentally.
However, for using 'UpdateStatus' the feature gate mentioned in the comment on line 326 needs to be enabled on the API Server. Ideally, the code could be written such that it checks if the gate is enabled and then decides whether to use 'Update' or 'UpdateStatus'. For now, the comment is referring to all of this and leaving the potential for improvement open.

from sample-controller.

mysterytony avatar mysterytony commented on July 17, 2024

@devdattakulkarni I see. Thank you!

Closing now.

from sample-controller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.