Comments (2)
@mysterytony No, the comment is correct. What it is referring to is the line 330. In that 'Update' method is used. The comment is saying that, instead of using the 'Update' method, more accurate would be to use the 'UpdateStatus' method since it is only the Status of the Custom Resource that we want to update. 'UpdateStatus' will update only the status and nothing else. With 'Update' it is programmer's responsibility to ensure that only the Status fields are updated and not any part of the Spec, even accidentally.
However, for using 'UpdateStatus' the feature gate mentioned in the comment on line 326 needs to be enabled on the API Server. Ideally, the code could be written such that it checks if the gate is enabled and then decides whether to use 'Update' or 'UpdateStatus'. For now, the comment is referring to all of this and leaving the potential for improvement open.
from sample-controller.
@devdattakulkarni I see. Thank you!
Closing now.
from sample-controller.
Related Issues (20)
- Metrics HOT 5
- Execute generate-groups.sh is failure HOT 6
- SharedInformer UpdateFunc triggers while Updating status HOT 4
- Got SECURITY ERROR when downloading k8s.io/client-go HOT 6
- Move CRD from `v1beta1` to `v1` HOT 3
- README is wrong on generating code when using Go modules HOT 5
- Please give a more detail readme, there are too many pitfall HOT 8
- `./hack/update-codegen.sh` fails on pristine checkout HOT 4
- go build with error sf.IsExported undefined HOT 8
- [enhancement] Move the code generator logic to a dockerfile HOT 2
- Generate the code with update-codegen.sh in a wrong path HOT 5
- Documentation error: example CRD already exists while trying to apply manually HOT 5
- How is the Deep Copy files are generated ? HOT 5
- Why has not the NewController use a leader election like leaderelection? HOT 4
- 无法执行生成 HOT 8
- How are the files crd.yaml and crd-status-subresource. yaml generated HOT 4
- State of the docs? HOT 4
- Why does fooInformer not register a delete event handling handler?
- code is not generated to correct dir HOT 4
- code generator errors HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sample-controller.