Giter Site home page Giter Site logo

Comments (6)

wojtek-t avatar wojtek-t commented on July 21, 2024

@gmarek @zmerlynn

from test-infra.

spxtr avatar spxtr commented on July 21, 2024

Does that mean detect-node-names only detects one node pool?

from test-infra.

spxtr avatar spxtr commented on July 21, 2024

https://github.com/kubernetes/kubernetes/blob/master/cluster/log-dump.sh#L102

from test-infra.

ixdy avatar ixdy commented on July 21, 2024

Sure looks that way. Compare GCE vs GKE.

Do we use detect-nodes or detect-node-names in any critical areas? Looks like it's just wrong for GKE with large clusters. @roberthbailey

from test-infra.

roberthbailey avatar roberthbailey commented on July 21, 2024

@fabioy

Yeah, that's broken for any GKE clusters that have >1 node pool. detect-node-instance-group will take the list of multiple instance group URLs and just return the name of the last one in the list.

from test-infra.

fabioy avatar fabioy commented on July 21, 2024

I'll take this one.

from test-infra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.