Giter Site home page Giter Site logo

Comments (7)

nikhiljindal avatar nikhiljindal commented on September 21, 2024 1

Have sent #335 so that anyone can type @k8s-bot federation gce e2e test this on any PR which will trigger federation tests with code in that PR.

That should help decrease some pain

from test-infra.

nikhiljindal avatar nikhiljindal commented on September 21, 2024

Ref kubernetes/kubernetes#26723

from test-infra.

nikhiljindal avatar nikhiljindal commented on September 21, 2024

This is blocking kubernetes-retired/contrib#1198.

@kubernetes/sig-testing who can help while @ixdy is out?

from test-infra.

spxtr avatar spxtr commented on September 21, 2024

You'll need to make a PR adding a new entry to this yaml file.

It looks like the federation tests take ~40 minutes to run on post-submit Jenkins. You'll have to cut out tests to get build + test time down to 30 minutes or so.

from test-infra.

nikhiljindal avatar nikhiljindal commented on September 21, 2024

Is it possible to run federation-e2e suite only if there is a change in federation/ directory?
That way only federation related PRs will be affected by the longer test running time, which might be acceptable?

from test-infra.

madhusudancs avatar madhusudancs commented on September 21, 2024

The trouble with watching for changes only in federation directory is, all our code is not in that directory. We use a ton of code from the packages outside and a change there could break us badly. See - kubernetes/kubernetes#29123 for example.

But having said that, having something that works is better than nothing. If it is easier to just watch for changes in the federation directory I think that should be a good start, but it is not worth building out the infrastructure for that if it doesn't exist already.

from test-infra.

nikhiljindal avatar nikhiljindal commented on September 21, 2024

Agreed. Its better to have federation e2e tests running at least on PRs that change code in federation/ dir, while we figure out how to reduce the run time of our test suite.

from test-infra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.