Giter Site home page Giter Site logo

Comments (12)

apelisse avatar apelisse commented on July 21, 2024 1

Yeah, please just let me know you would have 2 minutes to explain me what needs to be done :D

from test-infra.

foxish avatar foxish commented on July 21, 2024

The idea so far is to run the queue-health container as part of the submit-queue deployment. Does that sound ok?
From a cursory look, some refactoring seems to be needed to accept some parameters as flags. I can send a PR for that.

cc @fejta

from test-infra.

fejta avatar fejta commented on July 21, 2024

Yes putting the queue-health into the submit-queue deplyoment sgtm

from test-infra.

foxish avatar foxish commented on July 21, 2024

On second thought, it doesn't look like the volume of incoming PRs to the other repositories is very high and we may not even use the bot to perform merges, which would mean the queue-health charts aren't necessary yet for the other repos. So, perhaps there is no need to merge the two for now.

Spoke too soon. Looks like the plan is kubernetes/kubernetes#24343, in which case the individual charts would make sense.

from test-infra.

fejta avatar fejta commented on July 21, 2024

Is this still happening?

from test-infra.

foxish avatar foxish commented on July 21, 2024

@fejta Yes, I was a little sidetracked by other things. I'll get to this item again soon. It would now just be moving these containers into the submit-queue YAML and shouldn't be much effort.

from test-infra.

foxish avatar foxish commented on July 21, 2024

@apelisse Would you be able to take this? There isn't much left to be done, except to add these jobs to mungegithub/submit-queue/deployment.yaml, and then killing the separate deployments from the util cluster.

from test-infra.

apelisse avatar apelisse commented on July 21, 2024

OK, So it means you want to run this container from within the submit-queue deployment.yaml?

from test-infra.

foxish avatar foxish commented on July 21, 2024

@apelisse Yes, the grapher and poller containers should run as part of each submit-queue instance.

from test-infra.

apelisse avatar apelisse commented on July 21, 2024

I'll try to get this done when I have time :-)

from test-infra.

apelisse avatar apelisse commented on July 21, 2024

@foxish I'll try to deprecate that instead (and use velodrome)

from test-infra.

apelisse avatar apelisse commented on July 21, 2024

Feel free to close the issue, or keep it open until I have actually migrated ...

from test-infra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.