What we really testing in this piece of code?

[kurenn]

What we really testing in this piece of code?

[kurenn]

Answering your questions

1. Why we don't ever call our testable method #authenticate_with_token?
2. It is probably my mistake, I'll be working on the second edition of the book and try to fix this kind of issues.
3. As I understand, we only stubbing response object and check if stubbing was made perfecty? What is the sense?
4. I'm stubbing method calls that may affect the final expectation, what do you think we should do?
5. If I change this line

authentication.stub(:current_user).and_return(@user)

With this line they should not pass, are they passing?

[fatkodima]

4 If I write "#authenticate_with_token!" something like below, all tests should be of course passing. Are we really testing, that this method should respond to 401 and message "Not authenticated"?

module Authenticable

    def current_user
        @current_user ||= User.find_by(auth_token: request.headers['Authorization'])
    end

    def authenticate_with_token!
        render json: { ok: "You are welcome" },
                                status: :ok unless user_signed_in?
    end

    def user_signed_in?
        current_user.present?
    end

end

5 Yes, they are.

P.S. I find it as a better solution link:

  describe '.authenticate_with_token' do
    before do
      allow(authentication).to receive(:current_user).and_return(nil)
      allow(authentication).to receive(:render) do |args|
        args
      end
    end

    it 'returns error' do
      expect(authentication.authenticate_with_token![:json][:errors]).to eq 'Not authenticated'
    end

    it 'returns unauthorized status' do
      expect(authentication.authenticate_with_token![:status]).to eq :unauthorized
    end
  end

[zoran]

@fatkodima thanks for the link, this solution makes sense.

[kurenn]

Thanks @fatkodima for the information, it will definitely going to be updated on the second edition of the book

[danguyenwork]

@fatkodima @kurenn

Sorry to bring an old thread but can you tell me why?

    allow(authentication).to receive(:render) do |args| # возвращаем аргументы
          args
    end

is necessary? without it I get

undefined method "render"

[kurenn]

It is just stubbing the render call, so when the actual call is made, you allow the method to receive that call and give an ouput to it