ChoiceType broken for polymorphic identity

[danjac]

ChoiceType broken for polymorphic identity

[danjac]

It appears this issue is not just with polymorphic types, but with trying to save any ChoiceType column.

class User(Base):

    __tablename__ = 'users'

    TYPES = [
        (u'customer', 'Customer'),
        (u'admin', 'Admin'),
   ]

    id = Column(Integer, primary_key=True)
    type = Column(ChoiceType(TYPES), default='customer')
    email = Column(String(180), unique=True)
    is_active = Column(Boolean, default=True)

 session.add(User(type=u'admin', email='test')
 session.commit()

File "path/sqlalchemy-utils/sqlalchemy_utils/types/choice.py", line 107, in process_bind_param
return value.code
sqlalchemy.exc.StatementError: 'unicode' object has no attribute 'code' (original cause: AttributeError: 'unicode' object has no attribute 'code') u'INSERT INTO users (type, email, password,is_active) VALUES (?, ?, ?, ?, ?, ?, ?)' [{'type': u'admin', 'email': 'test'}]

So it appears the ChoiceType is completely broken, unless I'm missing something. The code should be something like:

def process_bind_param(self, value, dialect):
    if isinstance(value, Choice):
        return value.code
    return value

[kvesteri]

It seems you have not setup coercion_listener properly. See: http://sqlalchemy-utils.readthedocs.org/en/latest/coercion.html

[danjac]

Tried with the coercion_listener, same error:

listen(mapper, 'mapper_configured', coercion_listener)

[kvesteri]

DId you put the listener before the model definition? Clearly the problem is the unicode value does not get coerced to Choice object.

There is also a test case for this (which passes). So the problem must be with the data coercion. See: See: https://github.com/kvesteri/sqlalchemy-utils/blob/master/tests/types/test_choice.py#L39-L48

If you can reproduce the problem as a test case, that would be very helpful.

[danjac]

Yes, tried placing the call before and after the model definition. It could however be an issue with the import of a base class in another module (i.e it's called after the base class is defined), so I'll investigate that possibility.