Comments (3)
Doesn't cppimport
support Python 3.6 also? At least that is what I could find. However, I am not sure that we should require cppimport
. It is only used for probes, which is not needed to use turtleFSI
. The code for probes is copied from fenicstools
and it is also copied into VaMPy
. If we make VaMPy
into a package it is probably better to import it from there. Then we can remove the probes code from turtleFSI
.
I don't think we are using fenicstools
in turtleFSI
? I see it is mentioned in the documentation and that it is needed when using save_deg > 1
, but I don't see it being used anywhere in the code.
I see that Python 3.5 is no longer maintained, so it might be a good idea to bump the required version to 3.6.
from turtlefsi.
Doesn't
cppimport
support Python 3.6 also?
cppimport depends (https://github.com/tbenthompson/cppimport/blob/main/setup.py#L9) on Mako (https://pypi.org/project/Mako/) which only supports python 3.7 and upwards. Python 3.6 has reached End Of Life half a year ago, so I think we could skip that as well.
It is unclear how things depend on each-other in turtle. The docs says one thing, and you get tons of warnings without cppimport due to the probes. I think it would be good to iron out what are dependencies, and what should be where.
from turtlefsi.
Yes, I agree that we can skip Python 3.6 and that we should look into the dependencies.
from turtlefsi.
Related Issues (20)
- Which boundaries should be chosen to be included in bc_ids[]? HOT 3
- 3D FSI pipe flow problem
- Confirmation of a parameter of a standard case FSI3 HOT 2
- Adding multi-solid regions HOT 2
- Fix 1st lame coefficient in `TF_fsi`
- Fix drag and lift computations in TF problem HOT 2
- time loop conditional in `monolithic.py` HOT 4
- Replace `gravity` with `body force`
- some functions can not be found in this version of fenics in turtlefsi HOT 17
- xdmf file not correct when using `save_deg=2` and restart with different mesh patition HOT 3
- `merge_xml_files` does not work above python3.9 HOT 4
- Update documentation
- Update pytest HOT 1
- A question about CSM case HOT 2
- Some questions in the solid.py HOT 11
- Found no facets matching domain for boundary condition.(TF_csm) HOT 6
- Definitions of some quantities inside newtonsolver HOT 4
- Error in visualization of results in paraview (TF_fsi) HOT 11
- Pressure should not be part of save_deg >1 ? HOT 23
- checkpoint is only saving one time step, n-1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from turtlefsi.