Issue new release of TurtleFSI to generate DOI for Nature Comms Paper

[dbruneau-mie]

Issue new release of TurtleFSI to generate DOI for Nature Comms Paper

[johannesring]

No problem, but it would be good to bump the version number when making a release. There have been a few releases lately, but setup.py is still at version 1.5.

[johannesring]

@keiyamamo - yes, I will do that.

[dbruneau-mie]

I created a new release, but could not get zenodo to automatically create a DOI. I ended up archiving an older version of the repo manually at:

https://zenodo.org/doi/10.5281/zenodo.10001935

[keiyamamo]

There is no concerns from my side.

[jorgensd]

No objections. Frequent releases are good for users anyhow

[KristianValen-Sendstad]

No objection from me, DAB. KVS

…

On Thu, 12 Oct 2023 at 10:15, Johannes Ring ***@***.***> wrote: No problem, but it would be good to bump the version number when making a release. There have been a few releases lately, but setup.py is still at version 1.5. — Reply to this email directly, view it on GitHub <#92 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4X54JOPSSWRYEAVGRYVN3X7AQU5ANCNFSM6AAAAAA55Z237Q> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[dbruneau-mie]

Ok, I will increment the version number in setup.py. Have the recent versions code been passing the built-in pytest? DAB On Thu, Oct 12, 2023, 5:10 p.m. KristianValen-Sendstad < ***@***.***> wrote:

…

No objection from me, DAB. KVS On Thu, 12 Oct 2023 at 10:15, Johannes Ring ***@***.***> wrote: > No problem, but it would be good to bump the version number when making a > release. There have been a few releases lately, but setup.py is still at > version 1.5. > > — > Reply to this email directly, view it on GitHub > <#92 (comment)>, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AA4X54JOPSSWRYEAVGRYVN3X7AQU5ANCNFSM6AAAAAA55Z237Q> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > — Reply to this email directly, view it on GitHub <#92 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANWLGEMDGBFQL22K3N7WF53X7BMF5ANCNFSM6AAAAAA55Z237Q> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[johannesring]

Yes, the tests are passing (see here), but the badge at the top of README.md is pointing to a Travis test that does not seem to be running.

[keiyamamo]

@dbruneau-mie test is automatically run with github everyday. @johannesring We should probably remove travis from readme as well as .travis.yml

[keiyamamo]

@johannesring Thanks! For some reason, documentation badge says “failing” even though the documentation looks fine. It would be nice to fix it but I’m not sure when the documentation is built in the current setting.

[johannesring]

I guess the documentation on readthedocs is autobuilt on commits. It is probably configured on readthedocs.