RxJS 6

[kwonoj]

RxJS 6

[kwonoj]

Those import paths are relevant as application, sandbox barely have imports from rx affected by it, still need to double check though. I don't consider to use compat as dep / devdep of this pkg.

[kwonoj]

Sent out 1.0.0 https://www.npmjs.com/package/rx-sandbox, appreciate for taking time to look into this.

[kwonoj]

Thanks, I think it'll work OOTO only except peerdep warning, but will check and try to bump peerdependency if needed.

[ericadamski]

There are a few changes like https://github.com/ReactiveX/rxjs/blob/master/MIGRATION.md#import-paths that affect the usage of 6 without the rxjs-compat package.

I guess the current solution would be to have a dev dependency of the compat. That will eventually become deprecated.

[ericadamski]

I have a fork and am taking a look through the tests and upgrading the peer to 6.x.

[ericadamski]

@kwonoj I am having a little trouble running npm test | yarn test, is there something extra I have to do?

[kwonoj]

npm install / npm test should work (that's way current ci does) not sure what's missing.

[ericadamski]

Ah it seems that I needed to have the jest-cli installed globally

[ericadamski]

@kwonoj I am so sorry about bother you for all of this 😢

I have updated all the imports, tests are all 100%, I did a npm link to a package I am writing that uses only RxJS 6.x without the compat lib and it no longer throws the missing rxjs-compat error.

I am attempting to commit this using npm run commit so that I can submit a PR to you but I continue to get this error:

Am I doing something wrong, or did I break something?

Thank you for being so patient.

[kwonoj]

including jest-cli error above, I do suspect your npm installation behaves something odd. for example, any-observable is definitely dependency in lockfile https://github.com/kwonoj/rx-sandbox/blob/master/package-lock.json#L287 and it should be installed.

[ericadamski]

hum, I will do the classic rm -rf node_modules and give it another try.

[ericadamski]

That didn't work 😢

Here is the output

The only weird thing is

> [email protected] install /Users/Sgt-Wikkidoo/github/rx-sandbox/node_modules/weak
> node-gyp rebuild

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

[ericadamski]

Would it be OK to by-pass commitizen so you can pull the code?

[ericadamski]

I could just for it and publish it as rx-sandbox-6, if you don't want to move this version away from 5

[ericadamski]

@kwonoj anytime!