Buffer overflow in kwajd_read_headers()

[kyz]

Buffer overflow in kwajd_read_headers()

[kyz]

Thanks for the report!

This is in the logic for reading an 8.3 filename.ext, just looking over it I don't like how it's written and it could be better. The off-by-one could be avoided by allocating one or two more bytes for the filename, but I'd rather re-examine this code and check its logic is sound at the same time.

I'll check some test files that are intentionally bad (no null terminating byte in the filename, no null terminating byte in the extension), but another sample file would help. Could you supply the sample file that triggered this bug?

[jwilk]

overflow.kwaj.txt

[kyz]

Commit 0b0ef93 fixes this issue, thanks for reporting it!