Comments (5)
Yes, I'd like that too, and have tried and failed in the past.
The trouble is with the test programs finding their test files. They don''t have a hardcoded absolute path (and I'm not sure what would be the best way to ensure one - so the tests have to be run from the test
directory.
I'll look into this again, and see what can be done.
from libmspack.
This worked for me:
From 9bc56f680193458ea7662be96c4341e62779dd39 Mon Sep 17 00:00:00 2001
From: "Richard W.M. Jones" <[email protected]>
Date: Wed, 31 Oct 2018 11:05:21 +0000
Subject: [PATCH] Add test.
---
libmspack/.gitignore | 4 ++++
libmspack/Makefile.am | 2 ++
libmspack/configure.ac | 2 +-
libmspack/test/Makefile.am | 1 +
4 files changed, 8 insertions(+), 1 deletion(-)
create mode 100644 libmspack/test/Makefile.am
diff --git a/libmspack/.gitignore b/libmspack/.gitignore
index 1ca847d..1b44048 100644
--- a/libmspack/.gitignore
+++ b/libmspack/.gitignore
@@ -18,3 +18,7 @@ ltmain.sh
m4
missing
stamp-h1
+test-driver
+test/cabd_test.log
+test/cabd_test.trs
+test/test-suite.log
diff --git a/libmspack/Makefile.am b/libmspack/Makefile.am
index 20b6ab5..80a8577 100644
--- a/libmspack/Makefile.am
+++ b/libmspack/Makefile.am
@@ -1,3 +1,5 @@
+SUBDIRS = test
+
AUTOMAKE_OPTIONS = subdir-objects
EXTRA_DIST = $(srcdir)/debian/* $(srcdir)/doc/* $(srcdir)/test/test_files/*/*
pkgconfigdir = $(libdir)/pkgconfig
diff --git a/libmspack/configure.ac b/libmspack/configure.ac
index 5d6f833..5e6158a 100644
--- a/libmspack/configure.ac
+++ b/libmspack/configure.ac
@@ -50,5 +50,5 @@ AC_SYS_LARGEFILE
AC_FUNC_FSEEKO
# Checks for library functions.
-AC_CONFIG_FILES([Makefile doc/Makefile doc/Doxyfile libmspack.pc])
+AC_CONFIG_FILES([Makefile doc/Makefile doc/Doxyfile test/Makefile libmspack.pc])
AC_OUTPUT
diff --git a/libmspack/test/Makefile.am b/libmspack/test/Makefile.am
new file mode 100644
index 0000000..8e47325
--- /dev/null
+++ b/libmspack/test/Makefile.am
@@ -0,0 +1 @@
+TESTS = cabd_test
--
2.19.0.rc0
from libmspack.
After applying that patch you have to run:
automake --add-missing
autoconf
from libmspack.
It needs a bit more than that, because cabd_test and friends need to be built. And they depend on libmspack and friends being built before them. And I don't want to move away from there being only one Makefile.am
I've made changes in commit 43682d7, could you test them out?
from libmspack.
Both cabextract and libmspack now have "make check" test suites. Thanks for the suggestion and support.
from libmspack.
Related Issues (20)
- cabextract doesn't build from master HOT 2
- memory exhausted in oabd_decompress() HOT 2
- memory exhausted in chmd_read_headers() HOT 1
- Heap buffer overflow in chmd_read_headers() HOT 7
- Multiple filters in one command HOT 6
- 1.9.1: issue with dist tar ball HOT 2
- Not clear on Github how to get libmspack vs cabextract releases HOT 17
- chmextract HOT 2
- Conflicting definitions for copy_fh HOT 3
- configure / libtool fails with -flto HOT 12
- configure / libtool fails with -flto HOT 6
- Compilier warnings with 1.9.1 HOT 4
- Compiler error with 1.9.1 / gcc 9.3.1 HOT 5
- Malloc size error in chmd.c:1327:34 HOT 2
- extra = 0 confusion HOT 4
- build fails on macos HOT 1
- cabextract: Writing into symlinks HOT 11
- Issue with KWAJ method 2 decompression HOT 2
- Fail to properly create path components coming from the archive HOT 3
- Cannot extract files from a .cab file containing file names encoded in shift_JIS HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libmspack.