Could it possible to add exception logging into saveRelatedRecords function?

[la-haute-societe]

Could it possible to add exception logging into saveRelatedRecords function?

[mythicallage]

In my opinion, it looks pretty good. I don't see any better way to fix it. Thank you so much.

[juban]

Yes, you are right, it could totally be useful in a debugging context.
I'm thinking of adding a Yii:warning() log specifying the exception class name and message.
What do you think ?

[juban]

I have pushed an updated version of the saveRelatedRecords method into the master branch.
Could you test it and let me know if you have any issue?
Thanks.

[mythicallage]

Thank you. It was useful to find my mistake.

I was looking for improvements to save related models, but it is not as easy as I wanted. The main problem is that how to define an independent model and save it to avoid double saving attempts. I can't see any hint in \yii\db\BaseActiveRecord::getRelation, \yii\db\BaseActiveRecord::link.

e. g.
MainActiveRecord hasOne SubordinateActiveRecord.
Primary Key of MainActiveRecord is auto incremented.
I expected an attempt to save SubordinateActiveRecord after BaseActiveRecord::EVENT_AFTER_INSERT or EVENT_AFTER_UPDATE. But we have to run saving it twice for the universality of behavior.

[juban]

Upcoming 1.3.0 release will hopefully cover that more gracefully.
Your feedback is appreciated.