Comments (9)
@la10736 Thanks for replying so fast!
Change it today means introduce a breaking change.
Technically - yes, agreed (however, you're not 1.0 yet, so breaking changes are kind of expected?). However, to be honest I can't picture a real situation where this change would be actually breaking anything - except for a single test in rstest's test suite itself.
Remove it when there isn't any trace attribute
That sounds like the best way to do it, I think. If you're tracing things - you're going to be looking at stdout capture anyway. If you're not tracing anything - there's no reason to write anything to stdout.
Use a feature flag to enable it
You mean enable printlns if tracing is disabled? I think it's a bit of an overkill to be honest - can you imaging anyone having this flag turned on in their dev-dependencies? Why would they? If you want those printlns for whatever reason, it's a temporary thing and not a permanent one. Temporary things are usually enabled either at runtime or via env vars; permanent ones via cargo manifests. Maybe more suitable is an environment variable then instead of a feature flag?
from rstest.
from rstest.
@la10736 Wonder if there's any further thoughts on this? Or is any help with PR needed?
from rstest.
from rstest.
Ok, you've convinced me. I'll just remove it if there isn't any trace.
from rstest.
Done.
from rstest.
Done.
Thanks! 👍
from rstest.
It still shows to me. No trace flags was provided. or #[case] is trace, and I didn't understand correctly what it meant by it?
from rstest.
Oh it is unreleased yet. I see. So can live with this output for now, and wait for release.
Thanks!
from rstest.
Related Issues (20)
- allow to run individual parametrized test cases from vscode? HOT 1
- Is a stable, 1.0 release planned HOT 7
- Include fixtures in separate files HOT 4
- Inject case description? HOT 2
- `Wrong case signature` error on pattern in function parameter HOT 1
- `rstest_reuse`: Compiler error of rstest_reuse 0.5.0 with rstest 0.18.0 and 0.18.1 HOT 6
- Access files in parent directory to a repo HOT 9
- Generate tests from json files HOT 2
- [question] Test with different specializations of a generic type? HOT 4
- '#[once]' cleanup after tests executed HOT 1
- `#[ignore]` at the top only applies to the first case HOT 3
- Consider supporting `wasm-bindgen-test` for async test HOT 3
- Allow customizing the "length" of the test case names from the path HOT 1
- Separating test input data & expected values? HOT 1
- Unable to silence lints HOT 1
- New #[files] feature does not recompile on file change HOT 5
- Consider allowing to rename the crate by passing an attribute `crate = ...` to the proc-macro HOT 11
- vscode/rust-analyzer "debug overlay action" not working anymore HOT 2
- Question: tests failed by memory allocation of x bytes failure` when only running many cases once HOT 2
- Allow `clippy::too_many_arguments` HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rstest.