transaction service impl fails when auction has no winner.

[lagom]

transaction service impl fails when auction has no winner.

[yg-apaza]

I fixed this in my huge PR 😅
https://github.com/lagom/online-auction-java/blob/master/transaction-impl/src/main/java/com/example/auction/transaction/impl/TransactionServiceImpl.java#L35
I also added a integration test for this scenario: shouldNotCreateTransactionWithNoWinner

Since it's hard to review this wasn't clear, so from now, I'll make smaller PRs

[ignasi35]

The easiest way to have a no winner auction is to create an item on a 10 seconds auction, start the auction and let it finish without any bid.

[TimMoore]

Thanks for noticing, and sorry that I missed this.

@yg-apaza can you implement this fix, please? Be sure to add a test for this scenario... ideally add the test first to make sure it fails, then add the fix to make sure it fixes the test. 😄

[TimMoore]

Oh, great! @ignasi35 could you have not had the latest master when you raised this?

[ignasi35]

I found that on my working branch to test lagom 1.4.0-SNAPSHOT so I missed latest changes, yeah.