Comments (3)
Hi, my PR for this issue was merged. It is still open; does it need enhancement?
from online-auction-java.
@mehulsr this is done now. Thanks for pointing it out.
For future reference, GitHub has a convention where if you add "Fixes #56" (or whatever the issue number is) to the description of the pull request, it will close the issue automatically when the pull request is merged. So it's better to use this convention rather than putting the issue number in the title of the pull request, where GitHub doesn't look for it.
Here's GitHub's documentation on how this works: https://help.github.com/articles/closing-issues-via-commit-messages/
from online-auction-java.
@TimMoore Okay, will keep this in mind for the next PR. Thanks!
from online-auction-java.
Related Issues (20)
- Logout causes (UI and logs) exception HOT 1
- event store uniqueness , saga ,optimistic ui updates HOT 1
- TransportException on home page HOT 2
- Nav controller initialization failure in Japan locale HOT 1
- InvalidQueryException: Cannot execute this query as it might involve data filtering and thus may have unpredictable performance. HOT 1
- sbt runAll raise errro Unknown CF HOT 1
- logback stacktrace (NPE) when running in devmode HOT 3
- Disable java serialization completely HOT 1
- Add integration tests on Bidding Service
- Add LO4K8s instructions (remove ConductR) HOT 1
- Upgrade Elasticsearch to 6.x
- Replace the deprecated JavaTestKit with current equivalent
- Search service api expects a request body for GET request
- Replace ReadSideTestDriver with testkit-provided
- Cleanup Service descriptor for SearchService
- Upgrade to Lagom 1.5 HOT 1
- Upgrade to JUnit 5
- Fine tune Kafka logger levels
- Setup mergify
- Setup probot-settings
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from online-auction-java.