Giter Site home page Giter Site logo

Comments (5)

mhart avatar mhart commented on July 24, 2024 1

Trying to understand the use case – is it because you've added this check to your Lambda fn and you're trying to get coverage on it, or something similar to this?

If so, then I think the check itself (or at least, trying to get 100% coverage on it) is suspect. It's akin to checking whether the event arg exists, or whether the context arg has a get_remaining_time_in_millis property on it, and checking whether it's a function or not. You certainly could add these checks, but you really shouldn't. If these things aren't set, then there are much bigger problems πŸ˜‰

If this isn't the case you're trying to add this option for, then I think I still don't fully understand the use case

from docker-lambda.

mhart avatar mhart commented on July 24, 2024

@simonvanderveldt but they're always set on AWS Lambda

from docker-lambda.

simonvanderveldt avatar simonvanderveldt commented on July 24, 2024

@mhart Yeah, but that's not the case when running them locally in Docker :)
This is mainly meant for our CI since we want to automatically validate the Lambda's we write

from docker-lambda.

mhart avatar mhart commented on July 24, 2024

@simonvanderveldt but then I'm not sure what you mean by "validate the Lambdas we write"?

The variable is always set on AWS Lambda and this docker image / test runner is trying to replicate that environment as closely as possible

from docker-lambda.

mhart avatar mhart commented on July 24, 2024

Closing this – let me know if I've misunderstood your use case somehow

from docker-lambda.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.