Giter Site home page Giter Site logo

Random Field Element about lambdaworks HOT 8 CLOSED

lambdaclass avatar lambdaclass commented on August 16, 2024
Random Field Element

from lambdaworks.

Comments (8)

ilitteri avatar ilitteri commented on August 16, 2024 1

Can I take it?

Sure! The description is not updated yet, follow the guidelines of this comment.

from lambdaworks.

ilitteri avatar ilitteri commented on August 16, 2024 1

Hi, I cannot find IsFielElement trait, should it be included in IsField? or maybe IsField should be renamed to IsFielElement? Sorry for my ignorance, I'm not familiar with rust naming conventions yet.

The description is updated.

from lambdaworks.

gluax avatar gluax commented on August 16, 2024

UX should be considered here more. Rather than just defining a random method that uses a generic as an argument, we should implement the rand traits for the types.

It is more convenient and better for user experience when using the library.

from lambdaworks.

ilitteri avatar ilitteri commented on August 16, 2024

UX should be considered here more. Rather than just defining a random method that uses a generic as an argument, we should implement the rand traits for the types.

It is more convenient and better for user experience when using the library.

Thanks for the suggestion, you're right, we'll update the description!

Will do the same for #26.

from lambdaworks.

GianfrancoBazzani avatar GianfrancoBazzani commented on August 16, 2024

Can I take it?

from lambdaworks.

GianfrancoBazzani avatar GianfrancoBazzani commented on August 16, 2024

Hi, I cannot find IsFielElement trait, should it be included in IsField? or maybe IsField should be renamed to IsFielElement? Sorry for my ignorance, I'm not familiar with rust naming conventions yet.

from lambdaworks.

ilitteri avatar ilitteri commented on August 16, 2024

Hi, I cannot find IsFielElement trait, should it be included in IsField? or maybe IsField should be renamed to IsFielElement? Sorry for my ignorance, I'm not familiar with rust naming conventions yet.

IsFieldElement was the former name of FieldElement. You should implement it for FieldElement.

from lambdaworks.

MauroToscano avatar MauroToscano commented on August 16, 2024

This is done, though the code is not clear on that, we can create another issue to move it around

from lambdaworks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.