Cue files might reference bin files incorrectly

[lameguy64]

Cue files might reference bin files incorrectly

[Lameguy64]

I've just committed a quick fix that strips the path of the .bin file in the cue sheet that doesn't need that stupid filesystem library. I haven't been able to test it properly because msys64 seems to be broken as mkpsxiso throws a segfault when it starts to build the disc image (not related to my changes, crashes during the directory tree building process) and was unable to debug it with gdb as it fails to open source files and locks up on breakpoints, but the changes should work.

[ABelliqueux]

I've come up with a fix but it means switching to c++17 in order to have access to <filesystem> :

FWIW, the relevant code was here :

https://github.com/Lameguy64/mkpsxiso/blob/master/src/main.cpp#L306-L307

fprintf( cuefp, "FILE \"%s\" BINARY\n",
global::ImageName.c_str() );

ABelliqueux@869091d
ABelliqueux@1232e9d

Should I PR those changes ?

EDIT: PR links are dead

[SeaLiteral]

Building from the target directory seems possible but took me a couple of tries:

1. If I go into the build directory and run mkpsxiso -y -q ../iso.xml, it exits with the error ERROR: Unable to create cue sheet.
2. If I then replace the paths to the generated files, it says it can't find system.cnf (probably because it's looking for it in the build directory).
3. Finally, I removed all references to build/ in the XML file and added ../ to all paths that referred to source files. Then it seems to work as intended.

[64ghost]

This problem fixed in the fork https://github.com/brill2k/mkpsxiso

[ABelliqueux]

@Lameguy64 I can confirm it works after building the last commit on Linux. Cheers!

[SeaLiteral]

I can confirm it works after building the last commit on Linux. Cheers!

So can I. So I guess I could close this issue now, since the only issue from this that remains would be if you try to put the bin and cue files in different directories, which I don't see why people would want to do (other than to make it work differently in different emulators). Thanks!