Comments (5)
mchekin
commented on May 22, 2024
1
@michalbundyra
I would like to take care of this issue.
from laminas-code.
mchekin
commented on May 22, 2024
Maybe I do not understand the issue, but according to the source code:
https://github.com/laminas/laminas-code/blob/4.1.x/src/Generator/ParameterGenerator.php#L59-L65
And according to the tests:
https://github.com/laminas/laminas-code/blob/4.1.x/test/Generator/ParameterGeneratorTest.php#L506-L556
It seems like everything works as expected.
Am I missing something here?
from laminas-code.
Ocramius
commented on May 22, 2024
@mchekin the test checks ->isVariadic(), but not ->isOptional(), I think?
from laminas-code.
mchekin
commented on May 22, 2024
I created a pull request which prevents generating variadic parameters with default value + an accompanying unit test #72
from laminas-code.
Ocramius
commented on May 22, 2024
Handled in #72
from laminas-code.
Related Issues (20)
- Dependency Dashboard
- PHP 8.2 compability HOT 19
- Add setAttributes to ClassGenerator HOT 5
- Remove all `@deprecated` code from the component in `5.0.0`
- ClassGenerator syntax error, unexpected token ")" line 1096 HOT 2
- Tag parsers fail parsing typed array definition like array<int> HOT 4
- Implement generateShortOrCompleteClassname method for MethodGenerator and TypeGenerator HOT 4
- Missing line breaks in `DocBlockScanner::getLongDescription` result.
- Space after close parenthesis when return type is presen in the method generator HOT 3
- Issue with extending \ArrayObject HOT 3
- Laminas does not support union types HOT 1
- Promoted properties missing default value
- Promoted properties are losing nullable flag HOT 1
- TypeGenerator fails with type "null" cannot be nullable
- security venerability - see the report HOT 1
- PHP 8.3: New features
- Type "?array|string|null" is a union type, and therefore cannot be also marked nullable with the "?" prefix HOT 6
- Working with nullable properties. HOT 4
- Call to undefined method ReflectionUnionType::isBuiltin() HOT 6
- Support 8.0 and 8.2 HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from laminas-code.