Giter Site home page Giter Site logo

Comments (4)

falexwolf avatar falexwolf commented on September 15, 2024

OK, so we can fix the current problem (see commit above) by manually removing the wrong migration that was written here:

https://github.com/laminlabs/lndb-setup/blob/409cccb2f0c1677da497db4277c16216f9db9e7d/lndb_setup/_db.py#L106-L108

We can avoid writing a migration number if there is any query result on the migration_XXXX table. This will avoid that there is ever a wrong migration number written.

Maybe we can avoid storing _migration completely, which would be great as we'd then eliminate all danger for error due to redundancy.

from lnschema-core.

falexwolf avatar falexwolf commented on September 15, 2024

OK, so this should fix the issue for existing auto-migrating instances; the problem we just encountered:

However, an inconsistent version string will still affect new instances, and make them impossible to migrate.

from lnschema-core.

falexwolf avatar falexwolf commented on September 15, 2024

@fredericenard, could you rerun CI here after fixing the corrupted postgres instance?

The PR seems to be good otherwise.

from lnschema-core.

sunnyosun avatar sunnyosun commented on September 15, 2024

@falexwolf Is this still needed?

from lnschema-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.