Giter Site home page Giter Site logo

Comments (6)

pxpm avatar pxpm commented on September 28, 2024

Hello @bhavesh-hirani

My guess is that is failing because product_id id has already been indexed with index().

Could you try removing ->index() from product_id definition ?

Best,
Pedro

from laravel-5-generators-extended.

bhavesh-hirani avatar bhavesh-hirani commented on September 28, 2024

But the pivot migration code was generated by Laravel Generators. I did not change anything except adding a few extra columns. Also in previous Laravel version like 5.7, this worked without any issues.

I gave that a try and comes back with the same error.

I am using MySQL V5.7.26. DB Encoding is utf8mb4 and collation is utf8mb4_general_ci.

Looks like something else. I tried in a fresh Laravel install and same thing happens.

from laravel-5-generators-extended.

bhavesh-hirani avatar bhavesh-hirani commented on September 28, 2024

Can someone please help me on this?

from laravel-5-generators-extended.

bhavesh-hirani avatar bhavesh-hirani commented on September 28, 2024

Ok. So this is what fixed it. When I created the tables products and quotes using php artisan make:migration, a migration was created with $table->id(); by default for both tables. Previously in Laravel 5&6, that would create a column of INT. But in Laravel 7 BIGINT is used for id. And foreign key was not working for BIGINT. Once I changed the data type to INT, everything worked just fine.

from laravel-5-generators-extended.

hirani89 avatar hirani89 commented on September 28, 2024

Something more. laravel/framework#33642

According to that, BIGINT has been the default for id for 2 years now. So that means that migration code which is generated by the generators should match the fields as well. Any chance they can be BIGINT too?

from laravel-5-generators-extended.

tabacitu avatar tabacitu commented on September 28, 2024

I've just launched version 2.0.0 which makes bigInteger the default. So this should be fixed in 2.0.0.

If anybody else experiences this in 2.x please let me know and we'll reopen.

Cheers!

PS. Obviously sorry for the delayed response guys, this repo hasn't been a priority for me. I'd love to see more help from the community here, I think it's totally doable to take this to 0 issues and 0 PRs since this project's scope is very limited. I'd sleep a lot better then 😄 If anybody can help - by reviewing and testing existing PRs, or creating new PRs, please do, your help will be very appreciated.

from laravel-5-generators-extended.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.