Test class with no tests gives non-zero stderr status, but no warning to stdout and shows all tests pass

[selfsimilar]

Test class with no tests gives non-zero stderr status, but no warning to stdout and shows all tests pass

[driesvints]

I realize this isn't ideal but this isn't a realistic scenario tbh. An empty test class should be removed.

We would appreciate a PR however to make this UX better.

[selfsimilar]

This is absolutely a realistic scenario - this is a thing that has happened. I have junior programmers (work studies) who commented out WIP tests. There's no documentation that this is a hazard. Especially when local runs of Dusk appear to be passing and it looks fine to send to a stage or dev environment via CI. "Why is my build failing? All test are passing but the build stops at Dusk!"

I will happily work towards a PR on this, but please don't tell me "I'm holding it wrong" or "this is an unrealistic scenario". No warnings on a non-zero stderr is just not ok.

I've already done a little digging, and this may be more of a PHPUnit issue rather than a Dusk issue; that I might agree to. But if you're saying this isn't a problem, it will be harder for me to convince any other project to fix this issue.

[selfsimilar]

This is a bug in Collision

Issue and a PR for the fix

nunomaduro/collision#293

nunomaduro/collision#294

[Pacific01]

This is absolutely a realistic scenario - this is a thing that has happened. I have junior programmers (work studies) who commented out WIP tests.

Indeed its a realistic scenario.

I was working on a GitHub Action pipeline, php artisan dusk:install adds tests/Browser/ExampleTest.php by default, there is a testBasicExample that looks for "Laravel" text on the home page, making the pipeline automatically fail.

My solution was to add/commit test/Browser/ExampleTest.php with no tests on It... And 4 hours later of debugging sail dusk and asking myself why echo $? returns 1 if every test is on green? A real pain in the ***

[selfsimilar]

@Pacific01 - I dug in on this and discovered this is a downstream error from the Collision package that Dusk relies on. I've submitted a patch, but it is still unmerged. You could take that patch, or perhaps comment on the PR to see if that speeds the acceptance of the patch.