Giter Site home page Giter Site logo

Comments (1)

raftalks avatar raftalks commented on May 5, 2024

Yes, it is just how this line of code works https://github.com/laravel/framework/blob/master/src/Illuminate/Translation/Translator.php#L98

public function get($key, $parameters = array(), $locale = null)
    {
        list($namespace, $group, $item) = $this->parseKey($key);

        // Once we call the "load" method, we will receive back the "domain" for the
        // namespace and group. The "domain" is used by the Symfony translator to
        // logically separate related groups of messages, and should be unique.
        $domain = $this->load($group, $namespace, $locale);

        $line = $this->trans->trans($item, $parameters, $domain, $locale);

        return $line == $item ? $key : $line;
    }

I think it will be better to just return the $line without the conditional statement.

For example when simply returning the $line variable:

trans('test.rabbit') when not having the key still returns "rabbit" as default without the key.

I don't find any importance of returning the full $key string if the array key is not available. Instead we can return the $line.

@taylorotwell will know the reason behind that conditional statement.

from framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.