Unserialize DATETIME from Database not working with Carbon 3.0

[NiroDeveloper]

Unserialize DATETIME from Database not working with Carbon 3.0

[driesvints]

This is a change in Carbon v3. Please see the docs here: https://carbon.nesbot.com/docs/#api-carbon-3

[driesvints]

We also recommend to always call createFromTimestamp with 2 parameters (i.e. explicitly pass a timezone)

[NiroDeveloper]

Yes, this means that you can only give Carbon instances to laravel with the server-timezone, which is very confusing.
Instead laravel should regonize the different timezone and convert it into the configured server timezone.

@driesvints Assume that i have a REST API and the client sends his current timestamp as UTC.
Now i want to save this timestamp into the database ... it is fully correct that the Carbon instance is in the UTC Timezone, but laravel ignores this.

[driesvints]

I don't know what you want us to do? We don't control this code, this is all Carbon.

[NiroDeveloper]

We could fix this by adding a if-statement to

framework/src/Illuminate/Database/Query/Builder.php

Line 4065 in 5710fdb

public function castBinding($value)

public function castBinding($value)
{
   if ($value instanceof Carbon) {
       // The php date() function converts the timestamp into the server timezone.
       return date('Y-m-d H:i:s', $value->unix());
   }

   if ($value instanceof UnitEnum) {
       return $value instanceof BackedEnum ? $value->value : $value->name;
   }

   return $value;
}

Alternative we could read the app.timezone config or define a timezone in the database.connections config.
This will work for insert() only, for create() we have to also insert a "if" into HasAttribute->setAttribute()

This also makes the framework less dependent on external libs.

[driesvints]

I don't think we should do anything like that sorry. You should set the proper timezone as instructed by the Carbon docs.

[kylekatarnls]

Yes, this means that you can only give Carbon instances to laravel with the server-timezone, which is very confusing.

No it does not mean that, on the contrary the Carbon v2 behavior was actually using the server-timezone and you can get the Carbon v2 behavior by using:

$myDatetime = Carbon::createFromTimestamp(1657996631, date_default_timezone_get());

So I'm actually puzzled how you could get a +0000 timezone previously when using Carbon 2 and would be interested to dig that deeper.