Giter Site home page Giter Site logo

Make Caddy a brew dependency about valet HOT 4 CLOSED

laravel avatar laravel commented on June 28, 2024
Make Caddy a brew dependency

from valet.

Comments (4)

dbpolito avatar dbpolito commented on June 28, 2024

I can totally open a PR for this, i just wanted to double check before do anything.

from valet.

adamwathan avatar adamwathan commented on June 28, 2024

I think homebrew is probably the quirkiest part of the project that makes
us the most uncomfortable in terms of knowing everything always works on
every machine as expected, so the less we have to rely on homebrew the
better.

If we can bundle something up in a self contained portable way, there's a
lot less that can go wrong 👍🏻
On Wed, Aug 31, 2016 at 12:44 PM Daniel Polito [email protected]
wrote:

I can totally open a PR for this, i just wanted to double check before do
anything.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#137 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEH3bNSFh-ggDZ3Jc6iPXvRYMZyr9Vl1ks5qla9QgaJpZM4Jx0iY
.

from valet.

dbpolito avatar dbpolito commented on June 28, 2024

well they provide a download link and we can use curl instead of brew, and ignore this file on our bin folder.

Or keep receiving PRs like this: #135 to keep this updated, which is not thaaat bad.

from valet.

yuters avatar yuters commented on June 28, 2024

Well of course it's really bad if you accept my PR without bothering to compare the executable hash. :P

I agree that it shouldn't be a dependency, even more if there's plan for valet to support multiple OS.

from valet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.