Can we relax the pattern for JPGs?

[larskoelpin]

Can we relax the pattern for JPGs?

[LarsKoelpin]

acutally i noticed the pattern:
FF D8 FF E0

seems to be missing. Does yur image fall into this category?

[pastelmind]

Nope, mine is FF D8 FF E2. It contains a proprietary segment E2, but image viewers seem to ignore this and display the image data.

The structure of JPG makes it difficult to generalize the fourth byte, since some programs add arbitrary segments. See https://stackoverflow.com/a/5413049

[pastelmind]

Hey, thanks for adding 2ea4e40 in v1.8.0. But this addition would obsolete existing checks for JPEG, as they are now redundant:

magic-bytes/src/model/pattern-tree.ts

Lines 70 to 109 in 4beef5e

	add("jpg", ["0xFF", "0xD8", "0xFF", "0xDB"], {
	mime: "image/jpeg",
	extension: "jpeg",
	});
	add(
	"jpg",
	[
	"0xFF",
	"0xD8",
	"0xFF",
	"0xE0",
	"?",
	"?",
	"0x4A",
	"0x46",
	"0x49",
	"0x46",
	"0x00",
	"0x01",
	],
	{ mime: "image/jpeg", extension: "jpeg" }
	);
	add(
	"jpg",
	[
	"0xFF",
	"0xD8",
	"0xFF",
	"0xE1",
	"?",
	"?",
	"0x45",
	"0x78",
	"0x69",
	"0x66",
	"0x00",
	"0x00",
	],
	{ mime: "image/jpeg", extension: "jpeg" }
	);

I expected you to remove them altogether, but you left them in. Are these still necessary? If not, I'll submit a PR to delete them.

[LarsKoelpin]

You are right. Your PR is merged. Thanks